Skip to content

Targeting net481 and asp.net 5.2.9 #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 22, 2022
Merged

Targeting net481 and asp.net 5.2.9 #65

merged 11 commits into from
Sep 22, 2022

Conversation

bounav
Copy link
Collaborator

@bounav bounav commented Sep 21, 2022 •
edited
Loading

  • nant.build now uses msbuild.exe packaged with Visual Studio 2022
  • Modernised Spark.JsTests.csproj (new csproj format)
  • No longer building with different version of the Rhino Mocks DLL
  • Ignored a unit test for SpoolWriter. It simply never worked. Maybe it's due to targeting a different version of the .NET framework?
  • Removed binaries and dll from bin root folder. E.g. nant, nunit, rhino.mocks.

@bounav
Changed msbuild path to work with VS2022
2df4bed
@bounav
Fixed typo in class name.
fa1a7b4
@bounav
Targeting net481 instead of net45
f2bd2e2 
- Modernised project format of Spark.JsTests.csproj (web application with HttpHandler)
- Removed AssemblyInfo.cs from Spark.JsTests project (moved copyright info in csproj file)
@bounav
Ignored failing test
dc2335e
@bounav
Targeting Microsoft ASP.NET 5.2.9
2d353ec
@bounav bounav marked this pull request as draft September 21, 2022 12:58
@bounav
Removed <Reference Update /> elements from .csproj files
8b55c64
@bounav
Removed Rhino.Mocks.dll from bin folder (nuget pagckage used instead)
ddc040d
@bounav
Removed old nant binaries from the project.
5b536f5 
- Nant can be downloaded from http://nant.sourceforge.net/
@bounav
Nunit 2.x is now a nuget dependency
0228869 
- Updated from nunit v2.4.3 to v2.7.1
- Replaced deprecated Is.StringContaining() calls with Does.Contain() in unit tests
@bounav
Fixed nant path in build.cmd and build-distribution.cmd
86f0637 
- Added remark to explain nant is expected to be installed and the PATH environment variable
@bounav
Reintroduced TestFixtureSetUp obsolete attribute
fcb6142 
- This was was making the unit test misbehave because the nunit test runner built in nant-0.92 does not know about the new attribute
@bounav bounav marked this pull request as ready for review September 21, 2022 14:28
@bounav bounav changed the title More digital dusting - targeting net481 and asp.net 5.2.9 Targeting net481 and asp.net 5.2.9 Sep 21, 2022
RobertTheGrey
RobertTheGrey approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@RobertTheGrey RobertTheGrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work - upgrading those projects must've been tedious!

@bounav bounav merged commit 0dc742d into master Sep 22, 2022
@bounav bounav deleted the net481 branch September 22, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobertTheGrey RobertTheGrey RobertTheGrey approved these changes

Assignees

@RobertTheGrey RobertTheGrey

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bounav @RobertTheGrey