-
Notifications
You must be signed in to change notification settings - Fork 128
Use jmt
update proofs. Add Storage::Root
generic.
#908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
citizen-stig
approved these changes
Sep 22, 2023
Closed
citizen-stig
pushed a commit
that referenced
this pull request
Mar 26, 2025
* Refactor test framework * Refactoring test framework * Refactor batch building * Lint * Lint * Nit + merging with nightly * Cleanup testing framework batch building loop * Refactoring constants from test utils * Fix clippy + CHANGELOG * Docs * Addressing PR comments * PR comments * Adding test for current slot number * Adding test for current slot number * Reverting slot number change
cemozerr
pushed a commit
that referenced
this pull request
May 8, 2025
* Refactor test framework * Refactoring test framework * Refactor batch building * Lint * Lint * Nit + merging with nightly * Cleanup testing framework batch building loop * Refactoring constants from test utils * Fix clippy + CHANGELOG * Docs * Addressing PR comments * PR comments * Adding test for current slot number * Adding test for current slot number * Reverting slot number change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR switches from our temporary (insecure) method of proving updates to the new jmt update proofs that @theochap implemented while he was here. In order to make this change, it was convenient to clean up many of the hard-coded
[u8;32]
s scattered throughout the codebase and replace them with a genericStorage::Root
type.Linked Issues
Testing
This change is covered by existing tests.