Skip to content

Build: update Ecasound detection to use libecasoundc-config script #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Build: update Ecasound detection to use libecasoundc-config script #414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 21 additions & 18 deletions configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,24 +564,27 @@ ENABLE_AUTO([fudi-interface], [FUDI interface (needs Asio and {fmt})],

ENABLE_FORCED([ecasound], [Ecasound soundfile playback/recording],
[
dnl Checking for libecasoundc. It does not provide pkg-config and installs
dnl on some systems to non-standard path /usr/include/libecasoundc.
AC_MSG_CHECKING([for non-default libecasoundc include directory])
for incdir in {/usr,/usr/local,/opt,/opt/local,${HOMEBREW_PREFIX:-/opt/homebrew}}/include/libecasoundc; do
AS_IF([test -d $incdir], [ECASOUND_INCLUDE="$incdir"])
done
AS_IF([test x$ECASOUND_INCLUDE = x], [AC_MSG_RESULT([none found.])],
[
AC_MSG_RESULT([$ECASOUND_INCLUDE])
CPPFLAGS="$CPPFLAGS -I$ECASOUND_INCLUDE"
])

# now check with possibly redefined CPPFLAGS
AC_CHECK_HEADER([ecasoundc.h], , [have_ecasound=no])
AC_CHECK_HEADER([eca-control-interface.h], , [have_ecasound=no])
AC_SEARCH_LIBS([eci_init], [ecasoundc], , [have_ecasound=no])
AC_MSG_CHECKING([Ecasound library support (see above)])
AC_MSG_RESULT([$have_ecasound])
AC_MSG_CHECKING([for libecasoundc-config script])
AC_PATH_PROG([LIBECASOUND_CONFIG], [libecasoundc-config])
if test -z "$LIBECASOUND_CONFIG"; then
have_ecasound=no
AC_MSG_RESULT([not found])
AC_MSG_WARN([libecasoundc-config not found - Ecasound support will be disabled])
else
AC_MSG_RESULT([$LIBECASOUND_CONFIG])
ECASOUND_CFLAGS=`$LIBECASOUND_CONFIG --cflags`
ECASOUND_LIBS=`$LIBECASOUND_CONFIG --libs`
ECASOUND_PREFIX=`$LIBECASOUND_CONFIG --prefix`
CPPFLAGS="$CPPFLAGS $ECASOUND_CFLAGS"
LIBS="$LIBS $ECASOUND_LIBS"
AC_MSG_CHECKING([for ecasoundc.h via libecasoundc-config])
AC_CHECK_HEADER([ecasoundc.h], [have_ecasound=yes], [have_ecasound=no])
AC_MSG_CHECKING([for eca-control-interface.h via libecasoundc-config])
AC_CHECK_HEADER([eca-control-interface.h], , [have_ecasound=no])
AC_MSG_CHECKING([for Ecasound library via libecasoundc-config])
AC_SEARCH_LIBS([eci_init], [ecasoundc], , [have_ecasound=no])
AC_MSG_RESULT([$have_ecasound])
Comment on lines +580 to +586
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those checks still necessary? Wouldn't libecasoundc-config fail if those files aren't there?

Suggested change
AC_MSG_CHECKING([for ecasoundc.h via libecasoundc-config])
AC_CHECK_HEADER([ecasoundc.h], [have_ecasound=yes], [have_ecasound=no])
AC_MSG_CHECKING([for eca-control-interface.h via libecasoundc-config])
AC_CHECK_HEADER([eca-control-interface.h], , [have_ecasound=no])
AC_MSG_CHECKING([for Ecasound library via libecasoundc-config])
AC_SEARCH_LIBS([eci_init], [ecasoundc], , [have_ecasound=no])
AC_MSG_RESULT([$have_ecasound])

fi
])

AS_IF([test x$have_ecasound != xno],
Expand Down