Skip to content

SCANCLI-180 Change compilation to target Java 11 #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 8, 2025
Merged

SCANCLI-180 Change compilation to target Java 11 #223

merged 2 commits into from
Jul 8, 2025

Conversation

henryju
Copy link
Member

@henryju henryju commented May 6, 2025 •
edited by jira bot
Loading

SCANCLI-180

Needs manual testing, I don't think we can easily change ITs to run with Java 11.

@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented May 6, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@henryju henryju force-pushed the jh/SCANCLI-180_java_11 branch 3 times, most recently from 91b2b6c to 47fcd50 Compare July 7, 2025 15:39
@henryju
Run scanner commands in ITs with Java 11
b01478c 
When env variable JAVA_11_HOME is defined
@henryju henryju force-pushed the jh/SCANCLI-180_java_11 branch from 47fcd50 to b01478c Compare July 7, 2025 15:59
@henryju henryju marked this pull request as ready for review July 7, 2025 16:00
@henryju henryju requested a review from ericg138 July 7, 2025 16:00
@henryju
Copy link
Member Author

henryju commented Jul 7, 2025

We can see in logs that Java 11 is used in ITs, for example here: https://cirrus-ci.com/task/4583549833052160?logs=qa#L1490

@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Jul 7, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@ericg138
Copy link

ericg138 commented Jul 8, 2025

Do you know when SQS was updated to build with Java 17?
The scanner will fail for any version pre-new-bootstrapping (10.6) built with Java 17.

@henryju
Copy link
Member Author

henryju commented Jul 8, 2025

The scanner will fail for any version pre-new-bootstrapping (10.6) built with Java 17.

If you run the Scanner CLI with Java 11, yes, it will still fail later when bootstrapping SQ 10.5. But I guess people are already running with Java 17+ in this case.

ericg138
ericg138 approved these changes Jul 8, 2025
View reviewed changes
Copy link

@ericg138 ericg138 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by running an analysis with Java 11

image

@henryju henryju merged commit 22f2cb1 into master Jul 8, 2025
15 checks passed
@henryju henryju deleted the jh/SCANCLI-180_java_11 branch July 8, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericg138 ericg138 ericg138 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henryju @ericg138