JS-771 Support extra Sonar property for timeout of node bridge #5470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp-vault-sonar-prod
bot
changed the title
zglicz
commented
Jun 20, 2025
vdiez
reviewed
Jun 20, 2025
server.mjs
Outdated
Comment on lines
22
to
23
| const timeoutSeconds = | ||
| timeoutArg !== undefined && !isNaN(Number(timeoutArg)) ? Number(timeoutArg) : undefined; |
There was a problem hiding this comment.
Suggested change
| const timeoutSeconds = | |
| timeoutArg !== undefined && !isNaN(Number(timeoutArg)) ? Number(timeoutArg) : undefined; | |
| const timeoutSeconds = Number.parseInt(timeoutArg) || undefined; |
There was a problem hiding this comment.
forget about this, 0 needs to be supported
vdiez
approved these changes
Jun 20, 2025
vdiez
requested changes
Jun 23, 2025
Comment on lines
279
to
282
| public static int getNodeTimeoutSeconds(Configuration config) { | ||
| return config.getInt(NODE_TIMEOUT_PROPERTY).orElse(DEFAULT_TIMEOUT_SECONDS); | ||
| } | ||
|
|
There was a problem hiding this comment.
I would rather have all these helper function to get properties to JsTsContext.java
| private final BridgeServerImpl bridge; | ||
|
|
||
| public StandaloneParser() { | ||
| this(Http.getJdkHttpClient()); |
There was a problem hiding this comment.
I think we need to check with security about this change. Why was it needed in the first place.
| public static final String SONARJS_EXISTING_NODE_PROCESS_PORT = | ||
| "SONARJS_EXISTING_NODE_PROCESS_PORT"; | ||
| private static final Gson GSON = new Gson(); | ||
| private static final String BRIDGE_DEPLOY_LOCATION = "bridge-bundle"; | ||
|
|
||
| private final NodeCommandBuilder nodeCommandBuilder; | ||
| private final int timeoutSeconds; | ||
| private int timeoutSeconds = DEFAULT_TIMEOUT_SECONDS; |
There was a problem hiding this comment.
revert back and use different variables for request timeouts and node timeout
vdiez
reviewed
Jun 23, 2025
vdiez
approved these changes
Jun 23, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS-771