Skip to content

JS-628 S2699: Improved handling cross-file method calls #5339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 30, 2025
Merged

Conversation

zglicz
Copy link
Contributor

@zglicz zglicz commented Apr 29, 2025

JS-628

This update includes:

  • Using Typescript to resolve function calls
  • Fixing existing behavior, where a node is marked as visited, but doesn't carry the information that an assertion was found in it. This causes FP, when having multiple testcases use a separate method with an assertion. The first usecase, would correctly be marked as compliant, but the latter calls would be flagged as FP, as we don't visit their assertions.

TODO:

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title JS-628 improved S2699 JS-628 improved S2699 Apr 29, 2025
Base automatically changed from js-628 to master April 29, 2025 14:24
@zglicz zglicz changed the title JS-628 improved S2699 JS-628 S2699: Improved handling cross-file interations Apr 29, 2025
@zglicz zglicz requested a review from a team April 29, 2025 14:38
Copy link

sonarqube-next bot commented Apr 29, 2025

@zglicz zglicz changed the title JS-628 S2699: Improved handling cross-file interations JS-628 S2699: Improved handling cross-file method calls Apr 30, 2025
@zglicz zglicz merged commit 96658fc into master Apr 30, 2025
22 checks passed
@zglicz zglicz deleted the js-628-improved branch April 30, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants