Skip to content

JS-545 Configure renovate to use repox private npm registry #5313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025
Merged

Conversation

zglicz
Copy link
Contributor

@zglicz zglicz commented Apr 17, 2025

JS-545

As we noticed, renovate uses the public npm registry. Let us update this to first look in repox as the registry!
@jayadeep-km-sonarsource @hedinasr (I found your names as you've either previously touched this config or added a new source - https://sonarsource.atlassian.net/browse/BUILD-5885 ) - 2 questions:

  1. how can I test this?
  2. should this be added in the parent configs of renovate? I see that for maven we already have this in a common setup - https://github.com/SonarSource/renovate-config/blob/master/default.json#L22
    Could this come preconfigured for npm to use repox? As example see this pull request and the package-lock.json file -
    https://github.com/SonarSource/SonarJS/pull/5233/files
    We change all of the urls from repox to the public repository.

@zglicz zglicz requested review from hedinasr, jayadeep-km-sonarsource and a team April 17, 2025 13:27
Comment on lines +46 to +50
{
"matchUpdateTypes": ["minor", "patch"],
"matchCurrentVersion": "!/^0/",
"automerge": false
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was weirdly indented, moving to top level

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@zglicz
Copy link
Contributor Author

zglicz commented Apr 23, 2025

@hedinasr or @jayadeep-km-sonarsource - do you have any pointers/suggestions?

@jayadeep-km-sonarsource
Copy link
Contributor

Hi @zglicz ,
Changes looks good to me. I suggest you merge this and test it here. You can login to renovate, trigger the run and check the logs to validate if it is working as expected.
Moving this to renovate-config repo seems like a good idea. We will have to discuss internally and make sure that it will work with all the teams using it. I can bring it up to our squad discussion once you validate the changes in this repo.

@zglicz
Copy link
Contributor Author

zglicz commented Apr 24, 2025

@jayadeep-km-sonarsource Therefore, could you approve? I'm alone on the team for this week :)

@zglicz zglicz merged commit f9de6db into master Apr 24, 2025
25 of 26 checks passed
@zglicz zglicz deleted the js-545 branch April 24, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants