-
Notifications
You must be signed in to change notification settings - Fork 189
JS-550 Optimize the deduplication logic #5121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test to show that deduping works
...ascript-plugin/src/main/java/org/sonar/plugins/javascript/analysis/AbstractBridgeSensor.java
Outdated
Show resolved
Hide resolved
|
Is there a test showing that the deduplication actually worked? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, I missed the first reply, as it auto closed the conversation as it was outdated code. I'll try to get better filters on my github notifs.
JS-550