Skip to content

JS-550 Optimize the deduplication logic #5121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 19, 2025
Merged

JS-550 Optimize the deduplication logic #5121

merged 5 commits into from
Feb 19, 2025

Conversation

vdiez
Copy link
Contributor

@vdiez vdiez commented Feb 18, 2025

@vdiez vdiez requested a review from a team February 18, 2025 11:39
Copy link
Contributor

@zglicz zglicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test to show that deduping works

@vdiez vdiez requested a review from zglicz February 18, 2025 14:47
Copy link

sonarqube-next bot commented Feb 18, 2025

@zglicz
Copy link
Contributor

zglicz commented Feb 19, 2025

Is there a test showing that the deduplication actually worked?

@ericmorand-sonarsource
Copy link
Contributor

Is there a test showing that the deduplication actually worked?

@zglicz , yes, there is one:

As you can see, it is not located in the test suite where it should be.

Copy link
Contributor

@zglicz zglicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, I missed the first reply, as it auto closed the conversation as it was outdated code. I'll try to get better filters on my github notifs.

@vdiez vdiez merged commit 6f07f83 into master Feb 19, 2025
18 of 19 checks passed
@vdiez vdiez deleted the JS-550 branch February 19, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants