Add soiling endpoints to SDK #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lorenzo-solcast
left a comment
lorenzo-solcast
left a comment
There was a problem hiding this comment.
the design philosophy in the SDK is that only required params of the API are listed in the args of the SDK's functions, while all others are as kwargs. Same is valid for the docstrings. The reason being that:
- the source of truth is the API docs
- when a parameter changes in the API that is not always a breaking change
User can specify it through `kwargs` instead
mickpalmer
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included newly developed soiling endpoints (Kimber and HSU) into the SDK.
Also updated: