Skip to content

Conversation

@lboeman
Copy link
Contributor

@lboeman lboeman commented Mar 9, 2021

Handles a few issues with the system specification page.

  • Disables posting of invalid system spec.
  • Adds a second "Save System" button as proposed in dashboard review issues #88
  • Warns users of existing site with same name instead of allowing them to post and getting a 409 conflict.
  • closes Confusing Note about Single Axis #155 Changed warning text about single axis/multiple array to grayed out text for both conditions.
    Screenshot from 2021-03-09 12-09-31

@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #167 (a919ba3) into main (24492c9) will decrease coverage by 0.00%.
The diff coverage is 87.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
- Coverage   88.64%   88.64%   -0.01%     
==========================================
  Files          85       85              
  Lines        3426     3442      +16     
  Branches      289      294       +5     
==========================================
+ Hits         3037     3051      +14     
+ Misses        342      340       -2     
- Partials       47       51       +4     
Flag Coverage Δ
javascript 77.44% <87.87%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dashboard/src/components/model/Array.vue 97.95% <ø> (ø)
dashboard/src/components/model/Arrays.vue 90.00% <ø> (ø)
dashboard/src/components/model/Inverter.vue 77.77% <50.00%> (-3.00%) ⬇️
dashboard/src/components/ModelBase.vue 76.19% <83.33%> (+1.19%) ⬆️
dashboard/src/components/model/System.vue 95.45% <87.50%> (-4.55%) ⬇️
dashboard/src/views/SystemSpec.vue 96.61% <93.75%> (-1.58%) ⬇️
dashboard/src/types/Inverter.ts 100.00% <100.00%> (ø)
dashboard/src/store/mutations.ts 75.00% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24492c9...a919ba3. Read the comment docs.

@lboeman lboeman force-pushed the systemspec-error-handling branch from 0d0c71a to e48c594 Compare March 10, 2021 16:09
@lboeman lboeman force-pushed the systemspec-error-handling branch from 01018ad to a919ba3 Compare March 15, 2021 17:40
@lboeman lboeman merged commit 68727de into SolarPerformanceInsight:main Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confusing Note about Single Axis

2 participants