fix: fov drifting (waypoint blocks)

[P3nguinMinecraft]

fixed waypoint block offsetting because of fov not normalized (70)
it would affect and prob fix (or break) other renders that use setupCameraTransformations() but those do not work currently lol

couldnt figure out how to fix the nametags im just throwing rocks at a wall atp
only solution i have is just brute force calculating offset but that isnt great

[gemini-code-assist]

Summary of Changes

Hello @P3nguinMinecraft, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily addresses a Field of View (FOV) drifting issue that caused in-world rendered elements, such as waypoint blocks, to appear offset. It introduces a FOV normalization step to camera transformations for newer Minecraft versions to stabilize these renders. Additionally, it adjusts the rotation source for nametag rendering, though the author notes that the FOV-related issues for nametags are still a work in progress.

Highlights

• FOV Normalization for Camera Transformations: I've implemented a Field of View (FOV) normalization factor within the cameraRotation function in DrawHelper.kt. For Minecraft versions greater than 1.20.0, the camera's conjugate rotation is now multiplied by 70f/mc.options.fov.value. This change aims to correct FOV drifting issues, particularly for in-world elements like waypoint blocks, ensuring they remain correctly positioned regardless of the player's FOV setting.
• Nametag Rendering Rotation Adjustment: The drawNametag function has been updated to use mc.gameRenderer.camera.rotation instead of mc.entityRenderDispatcher.rotation for applying the rotation to the nametag's matrix stack. While this is an adjustment to the rotation source, a TODO comment has been added to indicate that the FOV drifting issues specifically for nametags are still unresolved and require further investigation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request aims to fix FOV drifting issues with waypoint blocks by normalizing the FOV in camera transformations. It modifies the cameraRotation function to account for the FOV setting and changes the rotation used for nametags. The changes include a potential division by zero and incorrect rotation for nametags.

[My-Name-Is-Jeff]

If the FOV is the cause for the rendering position issues, that would indicate that the projection matrix is incorrect? I feel like then we should aim to copy the MC projection matrix over but I'm not sure.

[P3nguinMinecraft]

this should at least fix for all box renders like in dungeons, text will need a diff fix