-
Notifications
You must be signed in to change notification settings - Fork 3
[KOA-6222] Stylelint 15, remove use-colors, remove use-tokens #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23937c1
to
d05bb20
Compare
This was referenced Jul 24, 2023
2b03987
to
a141bbe
Compare
⬆️ rebases main into branch |
olliecurtis
reviewed
Jul 24, 2023
CHANGELOG.md
Outdated
Comment on lines
8
to
11
## 3.0.0 | ||
|
||
- Update from stylelint 14.3.0 to 15.10.2 | ||
- Removed deprecated `use-colors` and `use-tokens` rules that were known to cause false positives |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will no longer need this as releases will be the source of truth :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Moved into PR description
olliecurtis
approved these changes
Jul 25, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be a major release.
It drops support for Stylelint < 15.
It deletes the
use-colors
anduse-tokens
rules that had been disabled instylelint-config-skyscanner
in 2021 for causing false positives: Skyscanner/stylelint-config-skyscanner#95