Skip to content

[KOA-6222] Stylelint 15, remove use-colors, remove use-tokens #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 25, 2023

Conversation

dominicfraser
Copy link
Contributor

@dominicfraser dominicfraser commented Jul 24, 2023

This will be a major release.

## 3.0.0

- Update from stylelint 14.3.0 to 15.10.2, drop support for > 15
- Removed deprecated `use-colors` and `use-tokens` rules that were known to cause false positives

It drops support for Stylelint < 15.

It deletes the use-colors and use-tokens rules that had been disabled in stylelint-config-skyscanner in 2021 for causing false positives: Skyscanner/stylelint-config-skyscanner#95

@olliecurtis olliecurtis force-pushed the KOA-6222_stylelint_15 branch from 2b03987 to a141bbe Compare July 24, 2023 13:24
@olliecurtis
Copy link
Member

⬆️ rebases main into branch

CHANGELOG.md Outdated
Comment on lines 8 to 11
## 3.0.0

- Update from stylelint 14.3.0 to 15.10.2
- Removed deprecated `use-colors` and `use-tokens` rules that were known to cause false positives
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will no longer need this as releases will be the source of truth :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Moved into PR description

@dominicfraser dominicfraser changed the title [KOA-6222] Stylelint 15, delete use-colors, delete use-tokens [KOA-6222] Stylelint 15, remove use-colors, remove use-tokens Jul 24, 2023
@olliecurtis olliecurtis merged commit e84b6b8 into main Jul 25, 2023
@olliecurtis olliecurtis deleted the KOA-6222_stylelint_15 branch July 25, 2023 07:54
@GCpigsic GCpigsic mentioned this pull request Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants