[ARGG-799]: Migrates from bpk-tokens to bpk-foundations-web #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olliecurtis
commented
Oct 24, 2023
| @@ -59,44 +48,7 @@ const BORDER_PROPS = [ | |||
| 'borderWidth', | |||
| ]; | |||
|
|
|||
| const SPACING_PROPS = [ | |||
There was a problem hiding this comment.
We don't track spacing now as the Backpack variables are no longer in JS and you can only set them via CSS
xalechez
reviewed
Oct 25, 2023
src/rules/use-tokens/use-tokens.js
Outdated
|
|
||
| if (expectedToken) { | ||
| const matchedTokens = _.filter(COLORS, { value: color.toRgbString() }); | ||
| console.log('matchedTokens', matchedTokens[0]); |
There was a problem hiding this comment.
Do we need this log statement?
There was a problem hiding this comment.
Ah good catch! That was left over from debugging
olliecurtis
force-pushed
the
ARGG-799-migrate-from-bpk-tokens
branch
from
eebe232 to
11ab711
Compare
olliecurtis
force-pushed
the
ARGG-799-migrate-from-bpk-tokens
branch
from
11ab711 to
0217b74
Compare
xalechez
approved these changes
Oct 26, 2023
This was referenced Apr 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some big changes to how the Backpack token linting works to move from
bpk-tokenstobpk-foundations-webas tokens is deprecated.Also in order to simplify and switch from tokens to foundations, based on the deprecation of support for React Native and Backpack React Native, removed the linting for Backpack React Native <- This was to avoid bundling two packages and making the big changes twice
Changes:
bpk-tokenstobpk-foundations-webUse Components
use-componentsrules and the React Native auto importer componentsUse Tokens
stylelint-config-skyscanner