Skip to content

Conversation

@hir06
Copy link
Contributor

@hir06 hir06 commented Oct 27, 2025

Screenshots:
Screenshot 2025-10-27 at 16 51 22
Screenshot 2025-10-27 at 16 49 51

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [Clover-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@hir06 hir06 added the minor Non breaking change label Oct 27, 2025
Copilot AI review requested due to automatic review settings October 27, 2025 15:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new interactive tabs example to the horizontal navigation component documentation, demonstrating how to implement stateful tab selection with click handlers.

Key Changes:

  • Added InteractiveTabsExample component showing useState hook integration with BpkHorizontalNav
  • Exported the new example in both examples.js and stories.js for Storybook documentation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
examples/bpk-component-horizontal-nav/examples.js Implements new InteractiveTabsExample component with state management and click handling
examples/bpk-component-horizontal-nav/stories.js Exports InteractiveTabsExample to make it available in Storybook

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hir06 hir06 changed the title [NO-TICKET] chore: adding interactive tabs example in horizontal-nav [NO-TICKET] [BpkHorizontalNav] chore: adding interactive tabs example in horizontal-nav Oct 27, 2025
@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/4029 to see this build running in a browser.

@Supremeyh Supremeyh merged commit 83b3fcc into main Oct 28, 2025
11 checks passed
@Supremeyh Supremeyh deleted the horizontal-nav-story branch October 28, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor Non breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants