Skip to content

Conversation

@IrinaWei
Copy link
Contributor

@IrinaWei IrinaWei commented Oct 10, 2025

In this PR:

  • Removes the SCSS upgrade script that was used for the migration process

  • Updates package.json to remove node-sass dependency and related configuration

  • Updates all documentation and references to use the stable bpk-mixins package instead of unstable__bpk-mixins

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [Clover-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

Copilot AI review requested due to automatic review settings October 10, 2025 07:59
@IrinaWei IrinaWei added the major Breaking change label Oct 10, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR completes the migration from legacy Sass API to modern Sass API by deprecating SCSS @import usage and removing the deprecated unstable__bpk-mixins package references throughout the codebase.

  • Removes the SCSS upgrade script that was used for the migration process
  • Updates package.json to remove node-sass dependency and related configuration
  • Updates all documentation and references to use the stable bpk-mixins package instead of unstable__bpk-mixins

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
scripts/scss/upgrade.sh Removes the migration script that converted @import to @use syntax
packages/package.json Removes node-sass peer dependency and its optional configuration
packages/bpk-mixins/README.md Updates import path from unstable__bpk-mixins to bpk-mixins
decisions/modern-sass-api.md Updates documentation to reflect completed migration to modern Sass API
CONTRIBUTING.md Updates development guidelines to use bpk-mixins instead of unstable__bpk-mixins
AGENTS.md Updates AI agent documentation with new import paths
.stylelintignore Removes the now-deprecated unstable__bpk-mixins from ignore list

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

CONTRIBUTING.md Outdated
* Import mixins from `packages/unstable__bpk-mixins` only. Otherwise your code will break because Modern SASS API doesn't support `~` import syntax or slash division
* Instead of blank import of all mixins, import them on demand. E.g. if you need only colour tokens, add `@use '../bpk-mixins/tokens'` statement only
3. Use `bpk-mixins` for Backpack components development
* If you need to add or modify a mixin, do it in `packages/bpk-mixins`, backpack now has formally deprecated `@import` usage and use Modern SASS API in `packages/bpk-mixins`
Copy link

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected capitalization of 'SASS' to 'Sass' to match the official brand name.

Suggested change
* If you need to add or modify a mixin, do it in `packages/bpk-mixins`, backpack now has formally deprecated `@import` usage and use Modern SASS API in `packages/bpk-mixins`
* If you need to add or modify a mixin, do it in `packages/bpk-mixins`, backpack now has formally deprecated `@import` usage and use Modern Sass API in `packages/bpk-mixins`

Copilot uses AI. Check for mistakes.
@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/4007 to see this build running in a browser.

1 similar comment
@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/4007 to see this build running in a browser.

@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/4007 to see this build running in a browser.

1 similar comment
@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/4007 to see this build running in a browser.

@IrinaWei IrinaWei changed the title [CLOV-792][Maintenance] Deprecate SCSS @import in Backpack Clean up [CLOV-793][Maintenance] Deprecate SCSS @import in Backpack Clean up Oct 10, 2025
@@ -1,30 +0,0 @@
# Backpack - Skyscanner's Design System
#
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remove this file because this file is only used for migration scss to modern scss and currently there is no scripts using it in the code base. It's added in this pr

@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/4007 to see this build running in a browser.

@IrinaWei IrinaWei changed the base branch from main to CLOV-792 October 13, 2025 07:53
@IrinaWei IrinaWei changed the base branch from CLOV-792 to main October 13, 2025 08:28
@IrinaWei IrinaWei changed the base branch from main to CLOV-792 October 13, 2025 08:34
@IrinaWei IrinaWei changed the base branch from CLOV-792 to main October 13, 2025 08:36
@IrinaWei IrinaWei changed the base branch from main to CLOV-792 October 13, 2025 08:58
gc-skyscanner
gc-skyscanner previously approved these changes Oct 13, 2025
Base automatically changed from CLOV-792 to main October 29, 2025 03:03
@Supremeyh Supremeyh dismissed gc-skyscanner’s stale review October 29, 2025 03:03

The base branch was changed.

@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/4007 to see this build running in a browser.

@Supremeyh Supremeyh merged commit 78e3c34 into main Oct 29, 2025
11 checks passed
@Supremeyh Supremeyh deleted the CLOV-793 branch October 29, 2025 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

major Breaking change v39

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants