-
Notifications
You must be signed in to change notification settings - Fork 203
[CLOV-793][Maintenance] Deprecate SCSS @import in Backpack Clean up #4007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… bpk-stylesheets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR completes the migration from legacy Sass API to modern Sass API by deprecating SCSS @import usage and removing the deprecated unstable__bpk-mixins package references throughout the codebase.
- Removes the SCSS upgrade script that was used for the migration process
- Updates package.json to remove
node-sassdependency and related configuration - Updates all documentation and references to use the stable
bpk-mixinspackage instead ofunstable__bpk-mixins
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/scss/upgrade.sh | Removes the migration script that converted @import to @use syntax |
| packages/package.json | Removes node-sass peer dependency and its optional configuration |
| packages/bpk-mixins/README.md | Updates import path from unstable__bpk-mixins to bpk-mixins |
| decisions/modern-sass-api.md | Updates documentation to reflect completed migration to modern Sass API |
| CONTRIBUTING.md | Updates development guidelines to use bpk-mixins instead of unstable__bpk-mixins |
| AGENTS.md | Updates AI agent documentation with new import paths |
| .stylelintignore | Removes the now-deprecated unstable__bpk-mixins from ignore list |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
CONTRIBUTING.md
Outdated
| * Import mixins from `packages/unstable__bpk-mixins` only. Otherwise your code will break because Modern SASS API doesn't support `~` import syntax or slash division | ||
| * Instead of blank import of all mixins, import them on demand. E.g. if you need only colour tokens, add `@use '../bpk-mixins/tokens'` statement only | ||
| 3. Use `bpk-mixins` for Backpack components development | ||
| * If you need to add or modify a mixin, do it in `packages/bpk-mixins`, backpack now has formally deprecated `@import` usage and use Modern SASS API in `packages/bpk-mixins` |
Copilot
AI
Oct 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected capitalization of 'SASS' to 'Sass' to match the official brand name.
| * If you need to add or modify a mixin, do it in `packages/bpk-mixins`, backpack now has formally deprecated `@import` usage and use Modern SASS API in `packages/bpk-mixins` | |
| * If you need to add or modify a mixin, do it in `packages/bpk-mixins`, backpack now has formally deprecated `@import` usage and use Modern Sass API in `packages/bpk-mixins` |
|
Visit https://backpack.github.io/storybook-prs/4007 to see this build running in a browser. |
1 similar comment
|
Visit https://backpack.github.io/storybook-prs/4007 to see this build running in a browser. |
|
Visit https://backpack.github.io/storybook-prs/4007 to see this build running in a browser. |
1 similar comment
|
Visit https://backpack.github.io/storybook-prs/4007 to see this build running in a browser. |
| @@ -1,30 +0,0 @@ | |||
| # Backpack - Skyscanner's Design System | |||
| # | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remove this file because this file is only used for migration scss to modern scss and currently there is no scripts using it in the code base. It's added in this pr
|
Visit https://backpack.github.io/storybook-prs/4007 to see this build running in a browser. |
Co-authored-by: Copilot <[email protected]>
The base branch was changed.
|
Visit https://backpack.github.io/storybook-prs/4007 to see this build running in a browser. |
In this PR:
Removes the SCSS upgrade script that was used for the migration process
Updates package.json to remove node-sass dependency and related configuration
Updates all documentation and references to use the stable bpk-mixins package instead of unstable__bpk-mixins
Remember to include the following changes:
[Clover-123][BpkButton] Updating the colourREADME.md(If you have created a new component)README.md