Skip to content

Commit a435841

Browse files
RichSutherSkyRichSutherSky
authored
[DON-1958] Add missing spacing tokens for Android and iOS (#468)
1 parent 8f5d732 commit a435841

File tree

6 files changed

+147
-75
lines changed

6 files changed

+147
-75
lines changed

‎packages/bpk-foundations-android/src/base/spacing.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,12 @@
2525
"SPACING_XXL": {
2626
"value": "{!SPACING_XXL}"
2727
},
28+
"SPACING_XXXL": {
29+
"value": "{!SPACING_XXXL}"
30+
},
31+
"SPACING_XXXXL": {
32+
"value": "{!SPACING_XXXXL}"
33+
},
2834
"SPACING_NONE": {
2935
"value": "{!SPACING_NONE}"
3036
},

‎packages/bpk-foundations-android/tokens/base.raw.android.json

Lines changed: 51 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -39,27 +39,33 @@
3939
"CAROUSEL_INDICATOR_DOT_SIZE_BASE": {
4040
"value": 6
4141
},
42-
"SPACING_SM": {
43-
"value": 4
44-
},
45-
"SPACING_MD": {
46-
"value": 8
47-
},
4842
"SPACING_BASE": {
4943
"value": 16
5044
},
51-
"SPACING_LG": {
52-
"value": 24
45+
"SPACING_XXXL": {
46+
"value": 64
5347
},
5448
"SPACING_XL": {
5549
"value": 32
5650
},
5751
"SPACING_XXL": {
5852
"value": 40
5953
},
54+
"SPACING_XXXXL": {
55+
"value": 96
56+
},
57+
"SPACING_MD": {
58+
"value": 8
59+
},
6060
"SPACING_NONE": {
6161
"value": 0
6262
},
63+
"SPACING_SM": {
64+
"value": 4
65+
},
66+
"SPACING_LG": {
67+
"value": 24
68+
},
6369
"FONT_WEIGHT_BOOK": {
6470
"value": "400"
6571
},
@@ -2953,33 +2959,19 @@
29532959
"originalValue": "{!ELEVATION_XXL}",
29542960
"name": "ELEVATION_XXL"
29552961
},
2956-
"SPACING_SM": {
2957-
"type": "size",
2958-
"category": "spacings",
2959-
"value": "4",
2960-
"originalValue": "{!SPACING_SM}",
2961-
"name": "SPACING_SM"
2962-
},
2963-
"SPACING_MD": {
2964-
"type": "size",
2965-
"category": "spacings",
2966-
"value": "8",
2967-
"originalValue": "{!SPACING_MD}",
2968-
"name": "SPACING_MD"
2969-
},
29702962
"SPACING_BASE": {
29712963
"type": "size",
29722964
"category": "spacings",
29732965
"value": "16",
29742966
"originalValue": "{!SPACING_BASE}",
29752967
"name": "SPACING_BASE"
29762968
},
2977-
"SPACING_LG": {
2969+
"SPACING_XXXL": {
29782970
"type": "size",
29792971
"category": "spacings",
2980-
"value": "24",
2981-
"originalValue": "{!SPACING_LG}",
2982-
"name": "SPACING_LG"
2972+
"value": "64",
2973+
"originalValue": "{!SPACING_XXXL}",
2974+
"name": "SPACING_XXXL"
29832975
},
29842976
"SPACING_XL": {
29852977
"type": "size",
@@ -2995,20 +2987,48 @@
29952987
"originalValue": "{!SPACING_XXL}",
29962988
"name": "SPACING_XXL"
29972989
},
2990+
"SPACING_XXXXL": {
2991+
"type": "size",
2992+
"category": "spacings",
2993+
"value": "96",
2994+
"originalValue": "{!SPACING_XXXXL}",
2995+
"name": "SPACING_XXXXL"
2996+
},
2997+
"SPACING_MD": {
2998+
"type": "size",
2999+
"category": "spacings",
3000+
"value": "8",
3001+
"originalValue": "{!SPACING_MD}",
3002+
"name": "SPACING_MD"
3003+
},
29983004
"SPACING_NONE": {
29993005
"type": "size",
30003006
"category": "spacings",
30013007
"value": "0",
30023008
"originalValue": "{!SPACING_NONE}",
30033009
"name": "SPACING_NONE"
30043010
},
3011+
"SPACING_SM": {
3012+
"type": "size",
3013+
"category": "spacings",
3014+
"value": "4",
3015+
"originalValue": "{!SPACING_SM}",
3016+
"name": "SPACING_SM"
3017+
},
30053018
"SPACING_ICON_TEXT": {
30063019
"type": "size",
30073020
"category": "spacings",
30083021
"value": "8",
30093022
"originalValue": "{!SPACING_MD}",
30103023
"name": "SPACING_ICON_TEXT"
30113024
},
3025+
"SPACING_LG": {
3026+
"type": "size",
3027+
"category": "spacings",
3028+
"value": "24",
3029+
"originalValue": "{!SPACING_LG}",
3030+
"name": "SPACING_LG"
3031+
},
30123032
"FONT_FAMILY": {
30133033
"value": "\"sans-serif\"",
30143034
"type": "font",
@@ -4187,14 +4207,16 @@
41874207
"ELEVATION_LG",
41884208
"ELEVATION_XL",
41894209
"ELEVATION_XXL",
4190-
"SPACING_SM",
4191-
"SPACING_MD",
41924210
"SPACING_BASE",
4193-
"SPACING_LG",
4211+
"SPACING_XXXL",
41944212
"SPACING_XL",
41954213
"SPACING_XXL",
4214+
"SPACING_XXXXL",
4215+
"SPACING_MD",
41964216
"SPACING_NONE",
4217+
"SPACING_SM",
41974218
"SPACING_ICON_TEXT",
4219+
"SPACING_LG",
41984220
"FONT_FAMILY",
41994221
"FONT_FAMILY_EMPHASIZE",
42004222
"FONT_FAMILY_HEAVY",

‎packages/bpk-foundations-common/app/spacing.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66
"SPACING_LG": 24,
77
"SPACING_XL": 32,
88
"SPACING_XXL": 40,
9+
"SPACING_XXXL": 64,
10+
"SPACING_XXXXL": 96,
911
"SPACING_NONE": 0
1012
}
1113
}

‎packages/bpk-foundations-ios/src/base/spacing.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,12 @@
2525
"SPACING_XXL": {
2626
"value": "{!SPACING_XXL}"
2727
},
28+
"SPACING_XXXL": {
29+
"value": "{!SPACING_XXXL}"
30+
},
31+
"SPACING_XXXXL": {
32+
"value": "{!SPACING_XXXXL}"
33+
},
2834
"SPACING_NONE": {
2935
"value": "{!SPACING_NONE}"
3036
},

‎packages/bpk-foundations-ios/tokens/base.ios.json

Lines changed: 31 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -2690,20 +2690,6 @@
26902690
"originalValue": "{!CAROUSEL_INDICATOR_DOT_SIZE_BASE}",
26912691
"name": "carouselIndicatorDotSizeBase"
26922692
},
2693-
{
2694-
"type": "size",
2695-
"category": "spacings",
2696-
"value": "4",
2697-
"originalValue": "{!SPACING_SM}",
2698-
"name": "spacingSm"
2699-
},
2700-
{
2701-
"type": "size",
2702-
"category": "spacings",
2703-
"value": "8",
2704-
"originalValue": "{!SPACING_MD}",
2705-
"name": "spacingMd"
2706-
},
27072693
{
27082694
"type": "size",
27092695
"category": "spacings",
@@ -2714,9 +2700,9 @@
27142700
{
27152701
"type": "size",
27162702
"category": "spacings",
2717-
"value": "24",
2718-
"originalValue": "{!SPACING_LG}",
2719-
"name": "spacingLg"
2703+
"value": "64",
2704+
"originalValue": "{!SPACING_XXXL}",
2705+
"name": "spacingXxxl"
27202706
},
27212707
{
27222708
"type": "size",
@@ -2732,20 +2718,48 @@
27322718
"originalValue": "{!SPACING_XXL}",
27332719
"name": "spacingXxl"
27342720
},
2721+
{
2722+
"type": "size",
2723+
"category": "spacings",
2724+
"value": "96",
2725+
"originalValue": "{!SPACING_XXXXL}",
2726+
"name": "spacingXxxxl"
2727+
},
2728+
{
2729+
"type": "size",
2730+
"category": "spacings",
2731+
"value": "8",
2732+
"originalValue": "{!SPACING_MD}",
2733+
"name": "spacingMd"
2734+
},
27352735
{
27362736
"type": "size",
27372737
"category": "spacings",
27382738
"value": "0",
27392739
"originalValue": "{!SPACING_NONE}",
27402740
"name": "spacingNone"
27412741
},
2742+
{
2743+
"type": "size",
2744+
"category": "spacings",
2745+
"value": "4",
2746+
"originalValue": "{!SPACING_SM}",
2747+
"name": "spacingSm"
2748+
},
27422749
{
27432750
"type": "size",
27442751
"category": "spacings",
27452752
"value": "8",
27462753
"originalValue": "{!SPACING_MD}",
27472754
"name": "spacingIconText"
27482755
},
2756+
{
2757+
"type": "size",
2758+
"category": "spacings",
2759+
"value": "24",
2760+
"originalValue": "{!SPACING_LG}",
2761+
"name": "spacingLg"
2762+
},
27492763
{
27502764
"category": "touchables",
27512765
"value": "0.15",

0 commit comments

Comments
 (0)