Skip to content

Commit 8f5d732

Browse files
olliecurtisolliecurtis
authored
[NO JIRA]: Update font-family-base to include Noto fallbacks (#469)
1 parent 34e8617 commit 8f5d732

File tree

7 files changed

+8
-8
lines changed

7 files changed

+8
-8
lines changed

‎packages/bpk-foundations-web/src/base/typography.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"imports": ["./aliases.json"],
33
"props": {
44
"FONT_FAMILY_BASE": {
5-
"value": "'Skyscanner Relative', -apple-system, BlinkMacSystemFont, 'Roboto', 'Oxygen', 'Ubuntu', 'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue', sans-serif",
5+
"value": "'Skyscanner Relative', 'Noto Sans Arabic', 'Noto Sans Hebrew', 'Noto Serif', 'Noto Serif Devanagari', 'Noto Serif Thai', 'Noto Sans SC', 'Noto Sans TC', 'Noto Sans JP', 'Noto Sans KR', -apple-system, BlinkMacSystemFont, 'Roboto', 'Oxygen', 'Ubuntu', 'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue', sans-serif",
66
"type": "font",
77
"category": "typesettings"
88
},

‎packages/bpk-foundations-web/tokens/base.common.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,7 @@ module.exports = {
391391
letterSpacingHero: "-0.04em",
392392
fontSizeRoot: "100%",
393393
fontSize6Xl: "4.75rem",
394-
fontFamilyBase: "'Skyscanner Relative', -apple-system, BlinkMacSystemFont, 'Roboto', 'Oxygen', 'Ubuntu', 'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue', sans-serif",
394+
fontFamilyBase: "'Skyscanner Relative', 'Noto Sans Arabic', 'Noto Sans Hebrew', 'Noto Serif', 'Noto Serif Devanagari', 'Noto Serif Thai', 'Noto Sans SC', 'Noto Sans TC', 'Noto Sans JP', 'Noto Sans KR', -apple-system, BlinkMacSystemFont, 'Roboto', 'Oxygen', 'Ubuntu', 'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue', sans-serif",
395395
fontWeightBold: "700",
396396
fontColorBase: "rgb(22, 22, 22)",
397397
lineHeightBaseTight: "1.25rem",

‎packages/bpk-foundations-web/tokens/base.default.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -778,7 +778,7 @@ $bpk-font-size-root: 100% !default;
778778
/// @group typesettings
779779
$bpk-font-size-6-xl: 4.75rem !default;
780780
/// @group typesettings
781-
$bpk-font-family-base: 'Skyscanner Relative', -apple-system, BlinkMacSystemFont, 'Roboto', 'Oxygen', 'Ubuntu', 'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue', sans-serif !default;
781+
$bpk-font-family-base: 'Skyscanner Relative', 'Noto Sans Arabic', 'Noto Sans Hebrew', 'Noto Serif', 'Noto Serif Devanagari', 'Noto Serif Thai', 'Noto Sans SC', 'Noto Sans TC', 'Noto Sans JP', 'Noto Sans KR', -apple-system, BlinkMacSystemFont, 'Roboto', 'Oxygen', 'Ubuntu', 'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue', sans-serif !default;
782782
/// @group font-weights
783783
$bpk-font-weight-bold: 700 !default;
784784
/// @group text-colors

‎packages/bpk-foundations-web/tokens/base.es6.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,7 @@ export declare const letterSpacingDisplay = "-0.05em" as const;
389389
export declare const letterSpacingHero = "-0.04em" as const;
390390
export declare const fontSizeRoot = "100%" as const;
391391
export declare const fontSize6Xl = "4.75rem" as const;
392-
export declare const fontFamilyBase = "'Skyscanner Relative', -apple-system, BlinkMacSystemFont, 'Roboto', 'Oxygen', 'Ubuntu', 'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue', sans-serif" as const;
392+
export declare const fontFamilyBase = "'Skyscanner Relative', 'Noto Sans Arabic', 'Noto Sans Hebrew', 'Noto Serif', 'Noto Serif Devanagari', 'Noto Serif Thai', 'Noto Sans SC', 'Noto Sans TC', 'Noto Sans JP', 'Noto Sans KR', -apple-system, BlinkMacSystemFont, 'Roboto', 'Oxygen', 'Ubuntu', 'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue', sans-serif" as const;
393393
export declare const fontWeightBold = "700" as const;
394394
export declare const fontColorBase = "rgb(22, 22, 22)" as const;
395395
export declare const lineHeightBaseTight = "1.25rem" as const;

‎packages/bpk-foundations-web/tokens/base.es6.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,7 @@ export const letterSpacingDisplay = "-0.05em";
389389
export const letterSpacingHero = "-0.04em";
390390
export const fontSizeRoot = "100%";
391391
export const fontSize6Xl = "4.75rem";
392-
export const fontFamilyBase = "'Skyscanner Relative', -apple-system, BlinkMacSystemFont, 'Roboto', 'Oxygen', 'Ubuntu', 'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue', sans-serif";
392+
export const fontFamilyBase = "'Skyscanner Relative', 'Noto Sans Arabic', 'Noto Sans Hebrew', 'Noto Serif', 'Noto Serif Devanagari', 'Noto Serif Thai', 'Noto Sans SC', 'Noto Sans TC', 'Noto Sans JP', 'Noto Sans KR', -apple-system, BlinkMacSystemFont, 'Roboto', 'Oxygen', 'Ubuntu', 'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue', sans-serif";
393393
export const fontWeightBold = "700";
394394
export const fontColorBase = "rgb(22, 22, 22)";
395395
export const lineHeightBaseTight = "1.25rem";

‎packages/bpk-foundations-web/tokens/base.raw.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3200,10 +3200,10 @@
32003200
"name": "FONT_SIZE_6XL"
32013201
},
32023202
"FONT_FAMILY_BASE": {
3203-
"value": "'Skyscanner Relative', -apple-system, BlinkMacSystemFont, 'Roboto', 'Oxygen', 'Ubuntu', 'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue', sans-serif",
3203+
"value": "'Skyscanner Relative', 'Noto Sans Arabic', 'Noto Sans Hebrew', 'Noto Serif', 'Noto Serif Devanagari', 'Noto Serif Thai', 'Noto Sans SC', 'Noto Sans TC', 'Noto Sans JP', 'Noto Sans KR', -apple-system, BlinkMacSystemFont, 'Roboto', 'Oxygen', 'Ubuntu', 'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue', sans-serif",
32043204
"type": "font",
32053205
"category": "typesettings",
3206-
"originalValue": "'Skyscanner Relative', -apple-system, BlinkMacSystemFont, 'Roboto', 'Oxygen', 'Ubuntu', 'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue', sans-serif",
3206+
"originalValue": "'Skyscanner Relative', 'Noto Sans Arabic', 'Noto Sans Hebrew', 'Noto Serif', 'Noto Serif Devanagari', 'Noto Serif Thai', 'Noto Sans SC', 'Noto Sans TC', 'Noto Sans JP', 'Noto Sans KR', -apple-system, BlinkMacSystemFont, 'Roboto', 'Oxygen', 'Ubuntu', 'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue', sans-serif",
32073207
"name": "FONT_FAMILY_BASE"
32083208
},
32093209
"FONT_WEIGHT_BOLD": {

‎packages/bpk-foundations-web/tokens/base.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -778,7 +778,7 @@ $bpk-font-size-root: 100%;
778778
/// @group typesettings
779779
$bpk-font-size-6-xl: 4.75rem;
780780
/// @group typesettings
781-
$bpk-font-family-base: 'Skyscanner Relative', -apple-system, BlinkMacSystemFont, 'Roboto', 'Oxygen', 'Ubuntu', 'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue', sans-serif;
781+
$bpk-font-family-base: 'Skyscanner Relative', 'Noto Sans Arabic', 'Noto Sans Hebrew', 'Noto Serif', 'Noto Serif Devanagari', 'Noto Serif Thai', 'Noto Sans SC', 'Noto Sans TC', 'Noto Sans JP', 'Noto Sans KR', -apple-system, BlinkMacSystemFont, 'Roboto', 'Oxygen', 'Ubuntu', 'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue', sans-serif;
782782
/// @group font-weights
783783
$bpk-font-weight-bold: 700;
784784
/// @group text-colors

0 commit comments

Comments
 (0)