Missing audioContextDescription?

[neophob]

Hi

I checked the file contextDescriptor_node.jsand saw that there are some entries are missing in the this.audioContextDescription array, for example

      "connect",
      "start",
      "getChannelData",
      "onaudioprocess"

See my js1k compo code here https://github.com/neophob/js1k17/blob/master/js1k.js. However I added those entries to the list and run the regpacker with those parameters: --useES6 true --hash2DContext --hashAudioContext --contextVariableName 'c' --crushGainFactor 2 --crushLengthFactor 1 --crushCopiesFactor 0. But the output file has the same size as before.

My question: does it make sense to extend the list or is this useless?

[Siorki]

I just double checked by listing all methods of an AudioContext and could not find any of those four.
They actually belong to other classes :

AudioNode.connect();
OscillatorNode.start();
AudioBuffer.getChannelData();
ScriptProcessorNode.onaudioprocess();

RegPack only adresses the instances of AudioContext ( v in your code) and not the other audio-related objects, as this is usually the object recording the most method and property calls.

So even after your tweak it was searching for v.connect() and ignoring l.connect() and n.connect(), hence the lack of extra gain you noticed.
Not a bug so far. Could we gain more by hashing also the Nodes and other objects ? Maybe, but this needs to be studied in depth first.

[neophob]

Hey @Siorki for looking into this. totally make sense.

Could we gain more by hashing also the Nodes and other objects

Yes I guess, but it might be difficult to find out what the most common use cases with the AudioContext are - as AudioContext will be seldom used without any generator (like oscillator, script processor etc)

[Siorki]

I'll look into this once js1k 2017 is over. No need to hurry !

[Siorki]

Link with #86 - the variable contains a string with the method name, that could be used on every object with a method by that name (connect() in this example)

[Siorki]

Output from #86 on your sample code :

----------- Storing property names into variables ----------- 
A="width" (x12) : gain = 28
B="height" (x9) : gain = 27
C="random" (x8) : gain = 23
D="fillStyle" (x5) : gain = 23
E="fillRect" (x5) : gain = 19
G="connect" (x5) : gain = 15
I="createGain" (x2) : gain = 3
L="fillText" (x2) : gain = 1

connect is processed and reduced to G .
start, getChannelData and onaudioprocess do not have enough occurrences to incur a gain (this new module is not a one-loop-processes-all like the other ones) and are left unchanged.