Skip to content

Change production config to encode duration as nanos #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Change production config to encode duration as nanos #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion zapgcp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ func (cfg *Config) ToZapConfig() (zap.Config, []zap.Option) {
LineEnding: zapcore.DefaultLineEnding,
EncodeLevel: encodeLevel,
EncodeTime: zapcore.RFC3339TimeEncoder,
EncodeDuration: zapcore.MillisDurationEncoder,
EncodeDuration: zapcore.NanosDurationEncoder,
EncodeCaller: zapcore.ShortCallerEncoder,
},
OutputPaths: []string{"stdout"},
Expand Down
2 changes: 1 addition & 1 deletion zapgcp_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ func TestProductionConfig(t *testing.T) {
logger.DPanic("testing dpanic", zap.Duration("time_til_implosion", 3*time.Millisecond), zap.Error(errors.New("divided by zero successfully")))

// DPanic should include a stacktrace, which will be machine-specific. So we just do a string match on the prefix.
wantPrefix := `{"severity":"CRITICAL","time":"1970-01-01T00:00:05Z","message":"testing dpanic","time_til_implosion":3,"error":"divided by zero successfully","stacktrace":"github.com/Silicon-Ally/zapgcp.TestProductionConfig`
wantPrefix := `{"severity":"CRITICAL","time":"1970-01-01T00:00:05Z","message":"testing dpanic","time_til_implosion":3000000,"error":"divided by zero successfully","stacktrace":"github.com/Silicon-Ally/zapgcp.TestProductionConfig`
lines := writer.Lines()
gotLine := lines[len(lines)-1]

Expand Down