Skip to content

Grady Review #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2022
Merged

Grady Review #1

merged 2 commits into from
Jul 11, 2022

Conversation

gbdubs
Copy link
Contributor

@gbdubs gbdubs commented Jul 11, 2022

No description provided.

@gbdubs gbdubs requested a review from bcspragu July 11, 2022 19:45
@gbdubs
Copy link
Contributor Author

gbdubs commented Jul 11, 2022

One other thing - I think this is WELL beyond the point where we need to the experimental disclaimer on it.

bcspragu
bcspragu approved these changes Jul 11, 2022
View reviewed changes
@bcspragu
Copy link
Contributor

One other thing - I think this is WELL beyond the point where we need to the experimental disclaimer on it.

The experimental + warning call outs are because I'm deeply unhappy with how it fetches dependencies. It pulls them over the internet instead of using the local ones already in your Bazel WORKSPACE, which is just straight up wrong. I should probably expand the warning to include that.

@gbdubs
Copy link
Contributor Author

gbdubs commented Jul 11, 2022

THanks for the clarification - I added that to the warning, and downgraded it to a NOTE.

@gbdubs gbdubs merged commit 3d0c63d into main Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcspragu bcspragu bcspragu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gbdubs @bcspragu