-
-
Notifications
You must be signed in to change notification settings - Fork 35
#40 Add jsonMapper into mappers #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#40 Add jsonMapper into mappers #43
Conversation
- added some tests for jsonMapper - added jsonMapper to README
…rfaces to start with a capitalized I
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 21 +1
Lines 301 311 +10
Branches 5 5
=========================================
+ Hits 301 311 +10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contribution ❤️
I have one proposition for you described in a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I has only one comment about rebase failed, everything else looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did merge instead of rebase.
LGTM now 😄
Thank you for this contribution, great job 👍
#36 FIX for horizontal merged cells in a loop.
If
TJsonResult
should be put somewhere else, just let me know :-)Should resolve #40