Skip to content

#40 Add jsonMapper into mappers #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 13, 2020
Merged

#40 Add jsonMapper into mappers #43

merged 5 commits into from
Oct 13, 2020

Conversation

Gontrum
Copy link

@Gontrum Gontrum commented Oct 12, 2020

If TJsonResult should be put somewhere else, just let me know :-)
Should resolve #40

  • added some tests for jsonMapper
  • added jsonMapper to README
  • added jsonMapper and a TJsonResponse-Type

David Gontrum added 2 commits October 12, 2020 15:48
- added some tests for jsonMapper
- added jsonMapper to README
@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #43 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #43   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        21    +1     
  Lines          301       311   +10     
  Branches         5         5           
=========================================
+ Hits           301       311   +10     
Impacted Files Coverage Δ
src/mappers/index.ts 100.00% <100.00%> (ø)
src/mappers/jsonMapper.ts 100.00% <100.00%> (ø)
tests/unit/mappers/stringMapper.test.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68e6110...2de79b2. Read the comment docs.

Copy link
Owner

@Siemienik Siemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution ❤️
I have one proposition for you described in a comment.

@Siemienik Siemienik mentioned this pull request Oct 12, 2020
4 tasks
Copy link
Owner

@Siemienik Siemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I has only one comment about rebase failed, everything else looks good to me 👍

Copy link
Owner

@Siemienik Siemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did merge instead of rebase.
LGTM now 😄

Thank you for this contribution, great job 👍

@Siemienik Siemienik merged commit 9969b70 into Siemienik:master Oct 13, 2020
Siemienik added a commit that referenced this pull request Nov 8, 2020
#36 FIX for horizontal merged cells in a loop.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add jsonMapper into mappers
2 participants