Skip to content

#37 Add isEmpty into mappers #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 12, 2020
Merged

#37 Add isEmpty into mappers #41

merged 2 commits into from
Oct 12, 2020

Conversation

Gontrum
Copy link

@Gontrum Gontrum commented Oct 12, 2020

Hi everyone.
This is my first first post and I hope everything is ok so far.
If something does not fit, please give me feedback.

Closes #37

  • created isEmpty with logic provided in tests
  • exported isEmpty in index.ts
  • added tests for isEmpty
  • added Example for isEmpty into README
  • listed isEmpty in mappers section of readme

- created isEmpty with logic provided in tests
- exported isEmpty in index.ts
@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #41 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #41   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        18    +1     
  Lines          279       286    +7     
  Branches         5         5           
=========================================
+ Hits           279       286    +7     
Impacted Files Coverage Δ
src/mappers/index.ts 100.00% <100.00%> (ø)
src/mappers/isEmpty.ts 100.00% <100.00%> (ø)
tests/unit/mappers/stringMapper.test.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e5c93a...d6adad2. Read the comment docs.

- listed isEmpty in mappers section of readme
Copy link
Owner

@Siemienik Siemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good for me :) Thank you for your first contribution here 👍

@Siemienik Siemienik merged commit 18b4006 into Siemienik:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add isEmpty into mappers
2 participants