Skip to content

Update s-form example code #3315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 2025-10-rc
Choose a base branch
from
Open

Update s-form example code #3315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd37d3c
delete removed accessibiltiyRole prop from examples
billfienberg Sep 17, 2025
521318a
add name attr to form examples
billfienberg Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/ui-extensions/src/surfaces/admin/components/Form/examples/default.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<s-form>
<s-text-field label="Email address" />
<s-button variant="primary" accessibilityRole="submit">Submit</s-button>
<s-text-field label="Email address" name="email" />
<s-button variant="primary">Submit</s-button>
</s-form>
4 changes: 2 additions & 2 deletions ...ages/ui-extensions/src/surfaces/checkout/components/Form/examples/basic-form.example.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<s-form onSubmit="console.log('Form submitted'); return false;">
<s-text-field label="Email address" />
<s-button accessibilityRole="submit">Submit</s-button>
<s-text-field label="Email address" name="email" />
<s-button>Submit</s-button>
</s-form>