activeresource 5.1.0 seems to breaking this gem

[kapso]

NoMethodError: undefined method `path' for nil:NilClass (Most recent call first)
File /app/vendor/bundle/ruby/2.5.0/gems/activeresource-5.1.0/lib/active_resource/base.rb line 701 in prefix
File /app/vendor/bundle/ruby/2.5.0/gems/activeresource-5.1.0/lib/active_resource/base.rb line 711 in prefix_source
File /app/vendor/bundle/ruby/2.5.0/gems/activeresource-5.1.0/lib/active_resource/base.rb line 1126 in prefix_parameters
File /app/vendor/bundle/ruby/2.5.0/gems/activeresource-5.1.0/lib/active_resource/base.rb line 1141 in block in split_options
File /app/vendor/bundle/ruby/2.5.0/gems/activeresource-5.1.0/lib/active_resource/base.rb line 1139 in each
File /app/vendor/bundle/ruby/2.5.0/gems/activeresource-5.1.0/lib/active_resource/base.rb line 1139 in split_options
File /app/vendor/bundle/ruby/2.5.0/gems/activeresource-5.1.0/lib/active_resource/base.rb line 1661 in split_options
File /app/vendor/bundle/ruby/2.5.0/gems/activeresource-5.1.0/lib/active_resource/base.rb line 1439 in load
File /app/vendor/bundle/ruby/2.5.0/gems/activeresource-5.1.0/lib/active_resource/base.rb line 1181 in initialize
File /app/vendor/bundle/ruby/2.5.0/gems/activeresource-5.1.0/lib/active_resource/base.rb line 1462 in new
File /app/vendor/bundle/ruby/2.5.0/gems/activeresource-5.1.0/lib/active_resource/base.rb line 1462 in block in load
File /app/vendor/bundle/ruby/2.5.0/gems/activeresource-5.1.0/lib/active_resource/base.rb line 1447 in each
File /app/vendor/bundle/ruby/2.5.0/gems/activeresource-5.1.0/lib/active_resource/base.rb line 1447 in load
File /app/vendor/bundle/ruby/2.5.0/gems/activeresource-5.1.0/lib/active_resource/base.rb line 1181 in initialize
File /app/vendor/bundle/ruby/2.5.0/gems/activeresource-5.1.0/lib/active_resource/base.rb line 1462 in new
File /app/vendor/bundle/ruby/2.5.0/gems/activeresource-5.1.0/lib/active_resource/base.rb line 1462 in block in load
File /app/vendor/bundle/ruby/2.5.0/gems/activeresource-5.1.0/lib/active_resource/base.rb line 1447 in each
File /app/vendor/bundle/ruby/2.5.0/gems/activeresource-5.1.0/lib/active_resource/base.rb line 1447 in load
File /app/vendor/bundle/ruby/2.5.0/gems/activeresource-5.1.0/lib/active_resource/base.rb line 1181 in initialize
File /app/vendor/bundle/ruby/2.5.0/gems/activeresource-5.1.0/lib/active_resource/base.rb line 1108 in new
File /app/vendor/bundle/ruby/2.5.0/gems/activeresource-5.1.0/lib/active_resource/base.rb line 1108 in instantiate_record
File /app/vendor/bundle/ruby/2.5.0/gems/activeresource-5.1.0/lib/active_resource/base.rb line 1097 in find_single
File /app/vendor/bundle/ruby/2.5.0/gems/activeresource-5.1.0/lib/active_resource/base.rb line 984 in find

[richter-alex]

Can you provide a little more info? Using activeresource 5.1.0 on shopify_api 5.2.0 yields no issues for me. Replication steps always appreciated.

[kapso]

This was during - ShopifyAPI::Order.find(id)

[richter-alex]

I cannot replicate by following that pattern. Can you provide more information? Such as what shopify_api version, a script demonstrating the issue, etc?

[kapso]

Hmm I am not sure what version of the Shopify API this gem uses. That info is abstracted out by this gem, no? Thats the whole purpose of this gem.

All I know is the Shopify requests like ShopifyAPI::Order.find(id) started failing after upgrading activeresource to 5.1.0.

[richter-alex]

To be clear, I'm asking about the gem version. This is visible in your environment or with the ShopifyAPI::VERSION constant during runtime.

[kapso]

Ah sorry, I am using the following Gem

shopify_app (8.3.2)
shopify_api (5.2.0)

[richter-alex]

Since I cannot replicate with the same shopify_api/activeresource/shopify_app gem versions, would you mind sharing a script that can be used to reliably replicate the issue? For example:

# Assuming shopify_api version 5.2.0 and activeresource version 5.1.0,
# and shopify_app version 8.3.2
session = ShopifyAPI::Session.new('shop.myshopify.com', access_token)
ShopifyAPI::Base.activate_session(session)

ShopifyAPI::Order.find(order_id)

[kapso]

Unfortunately cannot share the access token and store URL.

Do you think this could be a store specific issue?

[richter-alex]

I don't believe it's a store specific issue. You don't have to share the access token or shop URL if that's the case, and it's worth trying out. Just share a snippet like I showed in my last comment with dummy values.

The error specifically seems to be indicating that site is nil and therefore path is not defined here.

site is set on ShopifyApp::Base.activate_session here. activate_session pulls from the Session's site here which is set on ShopifyAPI::Session.new's url property here.

The above indicates that perhaps you're not instantiating a session properly? Anyway, looking forward to an example (with redacted sensitive information).

[dashmetriks]

I am also having an issue with the finding an order. I get output here https://doofdoof4.myshopify.com/admin/orders/569584451687.json, but get
ShopifyAPI::Order.find(569584451687)
ActiveResource::ResourceNotFound: Failed. Response code = 404. Response message = Not Found.
from /home/ec2-user/.rvm/gems/ruby-2.3.3/gems/activeresource-5.1.0/lib/active_resource/connection.rb:147:in `handle_response'

I am not sure if it is a date issue since 569584451687 has order date of 2018-08-16, because ShopifyAPI::Order.find(644479320167) of a recent order does give order data.

gem 'rails', '> 5.1.2'
ruby '2.3.3'
gem 'shopify_app', '> 7.2.0'
gem 'shopify_api', '~> 5.2'

gem list
activerecord (5.1.6, 5.1.5, 5.1.4, 5.1.2, 5.1.0)
activeresource (5.1.0, 5.0.0)
activesupport (5.1.6, 5.1.5, 5.1.4, 5.1.2, 5.1.0)

[richter-alex]

@dashmetriks your issue is unrelated to the one being discussed here.

If you don't have the read_all_orders access scope, you will have to request access to it under your specific app's area in your partner dashboard. Once you are given access to the scope, you can request read_all_orders during your installs, and you'll be able to see orders older than 60 days through the API.

See this announcement: https://ecommerce.shopify.com/c/api-announcements/t/action-required-apps-require-shopify-approval-to-read-orders-older-than-60-days-523231

[kapso]

@0ptimusrhyme But the same code (live production Shopify app) works fine with activeresource (5.0.0)

Here's the code, find_shopify_order fails with the above error when activeresource (5.1.0) is used

def find_shopify_order(id)
  shopify_request(ShopifyAPI::Order, :find, id)
end

def shopify_request(klass, method, *params)
  with_shopify_session { klass.send(method, *params) }
end

def with_shopify_session(&block)
  ShopifyAPI::Session.temp(shopify_store_domain, shopify_token, &block)
end

[kapso]

@0ptimusrhyme please let me know if you need any other data points. Thanks!

[harryjohn-dev]

I also have this issue when deploying to Heroku, but not locally....

[kapso]

BTW this issue got fixed for me. Only difference since I opened this issue was the shopify_* gems upgrade.

shopify_app (8.5.1)
shopify_api (5.2.4)