Latest Node 14 + 16 breaking tests/CI

[notjosh]

Overview

Node v14.19.0 and v16.14.0 were released in the last week or two, and are making their way to the CI runners.

Both of them include a bump to ICU (nodejs/node#40658), which is breaking some i18n related tests (locally and on CI). Note: CI still uses the previous Node 16 release, so only Node 14 is a problem there.

We can see on CI, two builds on the same commit from yesterday and today:

• yesterday: https://github.com/Shopify/quilt/runs/5131771206?check_suite_focus=true, uses v14.18.3, passes ✅
• today: https://github.com/Shopify/quilt/runs/5140374215?check_suite_focus=true, uses v14.19.0, fails ❌

This is reproducible locally also:

$ nvm install 14          # or 16
$ nvm use 14              # or 16
Now using node v14.19.0   # v16.14.0
$ yarn
$ yarn test packages/react-i18n/src/tests/i18n.test.ts

I believe it's calling into @shopify/dates for the formatting, but the failing tests are in @shopify/react-i18n.