Skip to content

Conversation

@liamstewart
Copy link

@liamstewart liamstewart commented Sep 23, 2025

What are you trying to accomplish with this PR?

The csv gem is removed from ruby core as of ruby 3.4. Using krane in such situations doesn't work:

render command - krane render ...
--
  | /root/local/ruby-3.4.4/lib/ruby/gems/3.4.0/gems/krane-3.6.1/lib/krane/bindings_parser.rb:4: warning: csv was loaded from the standard library, but is not part of the default gems starting from Ruby 3.4.0.
  | You can add csv to your Gemfile or gemspec to silence this warning.
  | /root/local/ruby-3.4.4/lib/ruby/3.4.0/bundled_gems.rb:82:in 'Kernel.require': cannot load such file -- csv (LoadError)
  | from /root/local/ruby-3.4.4/lib/ruby/3.4.0/bundled_gems.rb:82:in 'block (2 levels) in Kernel#replace_require'
  | from /root/local/ruby-3.4.4/lib/ruby/gems/3.4.0/gems/krane-3.6.1/lib/krane/bindings_parser.rb:4:in '<top (required)>'
  | from /root/local/ruby-3.4.4/lib/ruby/3.4.0/bundled_gems.rb:82:in 'Kernel.require'
  | from /root/local/ruby-3.4.4/lib/ruby/3.4.0/bundled_gems.rb:82:in 'block (2 levels) in Kernel#replace_require'
  | from /root/local/ruby-3.4.4/lib/ruby/gems/3.4.0/gems/krane-3.6.1/lib/krane/cli/render_command.rb:18:in 'Krane::CLI::RenderCommand.from_options'
  | from /root/local/ruby-3.4.4/lib/ruby/gems/3.4.0/gems/krane-3.6.1/lib/krane/cli/krane.rb:28:in 'block in Krane::CLI::Krane#render'
  | from /root/local/ruby-3.4.4/lib/ruby/gems/3.4.0/gems/krane-3.6.1/lib/krane/cli/krane.rb:77:in 'Krane::CLI::Krane#rescue_and_exit'
  | from /root/local/ruby-3.4.4/lib/ruby/gems/3.4.0/gems/krane-3.6.1/lib/krane/cli/krane.rb:27:in 'Krane::CLI::Krane#render'
  | from /root/local/ruby-3.4.4/lib/ruby/gems/3.4.0/gems/thor-1.4.0/lib/thor/command.rb:28:in 'Thor::Command#run'
  | from /root/local/ruby-3.4.4/lib/ruby/gems/3.4.0/gems/thor-1.4.0/lib/thor/invocation.rb:127:in 'Thor::Invocation#invoke_command'
  | from /root/local/ruby-3.4.4/lib/ruby/gems/3.4.0/gems/thor-1.4.0/lib/thor.rb:538:in 'Thor.dispatch'
  | from /root/local/ruby-3.4.4/lib/ruby/gems/3.4.0/gems/thor-1.4.0/lib/thor/base.rb:584:in 'Thor::Base::ClassMethods#start'
  | from /root/local/ruby-3.4.4/lib/ruby/gems/3.4.0/gems/krane-3.6.1/exe/krane:5:in '<top (required)>'
  | from /root/local/ruby-3.4.4/bin/krane:25:in 'Kernel#load'
  | from /root/local/ruby-3.4.4/bin/krane:25:in '<main>'

How is this accomplished?

Add csv as a dependency.

What could go wrong?

There could be problems if there's incompatible API changes between csv in ruby and the csv gem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant