Skip to content

[BFCL] Reorganizing Codes in ./bfcl/eval_checker/executable_eval/data/ #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

catherineruoxiwu
Copy link
Contributor

This PR includes 5 changes:

  1. Moved ./bfcl/eval_checker/executable_eval/data/api_status_check_ground_truth_REST.json to ./data/sanity_check/api_status_check_ground_truth_rest.json
  2. Moved ./bfcl/eval_checker/executable_eval/data/api_status_check_ground_truth_executable.json to ./data/sanity_check/api_status_check_ground_truth_executable.json
  3. Moved and renamed ./bfcl/eval_checker/executable_eval/data/rest-eval-response_v5.jsonl to ./data/possible_answer/BFCL_v3_rest.json
  • Format of this json file has been adjusted for consistency.
  • Corresponding ground truth fetching logics rest test category has been updated in ./bfcl/eval_checker/executable_eval/executable_checker.py.
  1. Deleted ./bfcl/eval_checker/executable_eval/data/ folder and moved the only file left ./bfcl/eval_checker/executable_eval/executable_python_function.py to its parent directory.
  2. A minor change in CONTRIBUTING.md to add documentation about ./bfcl/constants folder which is introduced in a previous PR.

@HuanzhiMao HuanzhiMao added BFCL-General General BFCL Issue BFCL-Dataset BFCL Dataset-Related Issue labels Apr 3, 2025
Copy link
Collaborator

@HuanzhiMao HuanzhiMao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR!

@HuanzhiMao HuanzhiMao merged commit d6b5fb8 into ShishirPatil:main Apr 3, 2025
@catherineruoxiwu catherineruoxiwu deleted the organize-sanity-check-code branch April 9, 2025 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFCL-Dataset BFCL Dataset-Related Issue BFCL-General General BFCL Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants