Skip to content

[BFCL] Remove Duplicate Line in record_cost_latency #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 17, 2024

Conversation

HuanzhiMao
Copy link
Collaborator

There is a duplicate line in the record_cost_latency function that would count the input and output token for each entry multiple times. It was due to a merge conflict.

This PR will not affect the leaderboard score, but will affect the cost and latency info.

@HuanzhiMao HuanzhiMao added the BFCL-General General BFCL Issue label Nov 17, 2024
@HuanzhiMao HuanzhiMao merged commit df81268 into ShishirPatil:main Nov 17, 2024
@HuanzhiMao HuanzhiMao deleted the cost-fix branch November 17, 2024 08:30
HuanzhiMao added a commit that referenced this pull request Nov 19, 2024
This PR updates the leaderboard to reflect the change in score due to
the following PR merge:

1. #719
2. #722
3. #723
4. #728 
5. #732
6. #725
7. #712
8. #733
9. #720 
10. #760 
11. #761 
12. #767
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFCL-General General BFCL Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants