Skip to content

Conversation

pgarbacki
Copy link
Contributor

@pgarbacki pgarbacki commented Jun 13, 2024

This PR adds firefunction-v2 to the leaderboard. It also updates the fireworks handler making sure that the parameters and prompt are set correctly.

@pgarbacki pgarbacki changed the title Update fireworks handler Add firefunction-v2 to the leaderboard Jun 13, 2024
Copy link
Collaborator

@HuanzhiMao HuanzhiMao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @pgarbacki. Excited to see the performance of firefunction-v2 on BFCL!

One minor issue, since the updated FireworkAIHandler still works for the old version of firefunction, we don't want to remove the mention of support for fire-function-v1-FC in the README. Could you change this line to |firefunction-{v1,v2}-FC | Function Calling|? Thanks!

@pgarbacki
Copy link
Contributor Author

Thanks for the PR @pgarbacki. Excited to see the performance of firefunction-v2 on BFCL!

One minor issue, since the updated FireworkAIHandler still works for the old version of firefunction, we don't want to remove the mention of support for fire-function-v1-FC in the README. Could you change this line to |firefunction-{v1,v2}-FC | Function Calling|? Thanks!

Done. Thanks for the review.

Copy link
Owner

@ShishirPatil ShishirPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShishirPatil ShishirPatil merged commit 2f39693 into ShishirPatil:main Jun 19, 2024
ShishirPatil pushed a commit that referenced this pull request Jun 22, 2024
This PR adds the new model `firefunction-v2-FC` to the leaderboard,
thanks to the support from @pgarbacki in #470.
This PR only adds an entry in the leaderboard; the score for all other
models on the leaderboard will remain unchanged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants