[BFCL] Standardize Model Name Among handler_map and eval_runner_helper #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Edit, we will do it the other way around. We will switch to the version where the model name contains |
ShishirPatil
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR standardize the model name among
handler_mapandeval_runner_helper. In the past, thehandler_mapused the model name that contains/while theeval_runner_helpertakes the model name that has the/substituted with_. This caused a lot of unnecessary confusion when trying to add new models, so this PR addresses it by letting theeval_runner_helperadapt to thehandler_mapformat.This PR DOES NOT affect the leaderboard score.