Skip to content

GoEx Gitignore User Credentials #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 14, 2024
Merged

GoEx Gitignore User Credentials #344

merged 4 commits into from
Apr 14, 2024

Conversation

royh02
Copy link
Collaborator

@royh02 royh02 commented Apr 11, 2024

Make sure that user creds aren't version tracked. Ex: credentials/slack needs to be ignored as well

@royh02 royh02 changed the title Gitignore User Credentials GoEx: Gitignore User Credentials Apr 11, 2024
@royh02 royh02 changed the title GoEx: Gitignore User Credentials GoEx Gitignore User Credentials Apr 11, 2024
@Noppapon
Copy link
Collaborator

But we do want to track other files inside that folder, for example supported.txt. We should not use * and only selectively untrack a subset of the files?

@royh02
Copy link
Collaborator Author

royh02 commented Apr 11, 2024

Right. Added exlusion patterns and tested locally that changes in credentials/credentials_utils.py and credentials/supported.txt still show up, but everything else is still ignored.

Copy link
Collaborator

@Noppapon Noppapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! It might be worth moving credentials_utils.py and supported.txt, or the user's credentials, so they are in different folders. However, I think it's okay to merge this for now.

Copy link
Owner

@ShishirPatil ShishirPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShishirPatil ShishirPatil merged commit ef994a0 into main Apr 14, 2024
@ShishirPatil ShishirPatil deleted the goex-gitignore-creds branch April 14, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants