Skip to content

Add ASCII renderer optimizations #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2025
Merged

Add ASCII renderer optimizations #652

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9590d2e
Add ASCII renderer optimizations
Shane32 Oct 7, 2025
cef1680
Update QRCoder/ASCIIQRCode.cs
Shane32 Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 29 additions & 4 deletions QRCoder/ASCIIQRCode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ public string GetGraphic(int repeatPerModule, string darkColorString = "██",
/// <returns></returns>
public string[] GetLineByLineGraphic(int repeatPerModule, string darkColorString = "██", string whiteSpaceString = " ", bool drawQuietZones = true)
{
var qrCode = new List<string>();
//We need to adjust the repeatPerModule based on number of characters in darkColorString
//(we assume whiteSpaceString has the same number of characters)
//to keep the QR code as square as possible.
Expand All @@ -55,9 +54,34 @@ public string[] GetLineByLineGraphic(int repeatPerModule, string darkColorString
var adjustmentValueForNumberOfCharacters = darkColorString.Length / 2 != 1 ? darkColorString.Length / 2 : 0;
var verticalNumberOfRepeats = repeatPerModule + adjustmentValueForNumberOfCharacters;
var sideLength = (QrCodeData.ModuleMatrix.Count - quietZonesModifier) * verticalNumberOfRepeats;
var qrCode = new string[sideLength];
var lineCapacity = (QrCodeData.ModuleMatrix.Count - quietZonesModifier) * repeatPerModule * darkColorString.Length;
#if HAS_SPAN
if (darkColorString.Length == whiteSpaceString.Length && lineCapacity < 510)
{
Span<char> row = stackalloc char[512].Slice(0, lineCapacity);
for (var y = 0; y < sideLength; y++)
{
var offset = 0;
for (var x = 0; x < QrCodeData.ModuleMatrix.Count - quietZonesModifier; x++)
{
var module = QrCodeData.ModuleMatrix[((y + verticalNumberOfRepeats) / verticalNumberOfRepeats - 1) + quietZonesOffset][x + quietZonesOffset];
for (var i = 0; i < repeatPerModule; i++)
{
var sourceSpan = module ? darkColorString.AsSpan() : whiteSpaceString.AsSpan();
var targetSpan = row.Slice(offset, darkColorString.Length);
sourceSpan.CopyTo(targetSpan);
offset += darkColorString.Length;
}
}
qrCode[y] = row.ToString();
}
return qrCode;
}
#endif
var lineBuilder = new StringBuilder(lineCapacity);
for (var y = 0; y < sideLength; y++)
{
var lineBuilder = new StringBuilder();
for (var x = 0; x < QrCodeData.ModuleMatrix.Count - quietZonesModifier; x++)
{
var module = QrCodeData.ModuleMatrix[((y + verticalNumberOfRepeats) / verticalNumberOfRepeats - 1) + quietZonesOffset][x + quietZonesOffset];
Expand All @@ -66,9 +90,10 @@ public string[] GetLineByLineGraphic(int repeatPerModule, string darkColorString
lineBuilder.Append(module ? darkColorString : whiteSpaceString);
}
}
qrCode.Add(lineBuilder.ToString());
qrCode[y] = lineBuilder.ToString();
lineBuilder.Length = 0;
}
return qrCode.ToArray();
return qrCode;
}

/// <summary>
Expand Down