fix(Popup): apply Popper attributes to wrapper div #4529
Closed
+117,290
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thanks for opening this pull request! 💖 Here is a list of things that will help get it across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* chore(eslint): enable react-hooks eslint rules * chore(eslint): ignore eslint error as it is false positive because process.env.NODE_ENV never changes during runtime
aabidali641
force-pushed
the
fix/popup-apply-popper-attributes
branch
from
b757084 to
68954b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where Popper's attributes (
data-popper-escaped,data-popper-reference-hidden)were not being applied to the Popup wrapper div.
Added support for applying state.attributes.popper to the wrapper element.
Fixes #4488.