Skip to content

chore(eslint): enable react-hooks/recommended #4498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 22, 2024
Merged

chore(eslint): enable react-hooks/recommended #4498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae26fb0
chore(eslint): enable react-hooks eslint rules
dominikdosoudil Nov 22, 2024
43ca40b
chore(eslint): ignore eslint error as it is false positive because pr…
dominikdosoudil Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"root": true,
"parser": "babel-eslint",
"extends": ["airbnb", "prettier"],
"extends": ["airbnb", "prettier", "plugin:react-hooks/recommended"],
"env": {
"browser": true
},
Expand Down
3 changes: 3 additions & 0 deletions src/modules/Accordion/AccordionAccordion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ const AccordionAccordion = React.forwardRef(function (props, ref) {
})

if (process.env.NODE_ENV !== 'production') {
// Following eslint error is ignored because process.env.NODE_ENV does not change during runtime,
// so it is not actually a problem because the useEffect will be called either always or never
// eslint-disable-next-line react-hooks/rules-of-hooks
React.useEffect(() => {
/* eslint-disable no-console */
if (exclusive && typeof activeIndex !== 'number') {
Expand Down
Loading