-
-
Couldn't load subscription status.
- Fork 8.6k
[JS] Add websocket port option in Firefox ServiceBuilder when '--connect-existing' is not passed #15557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ect-existing' is not passed
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||
CI Feedback 🧐(Feedback updated until commit 4f8488c)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Test failures are not related to the changes in this PR.
User description
Fixes #15451
🔗 Related Issues
💥 What does this PR do?
🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes
PR Type
Bug fix, Enhancement
Description
Added support for
--websocket-portargument in Firefox ServiceBuilder.Ensured the websocket port is only added when
--connect-existingis not passed.Integrated logic to dynamically find free ports for both service and websocket.
Changes walkthrough 📝
firefox.js
Added websocket port logic in Firefox ServiceBuilderjavascript/selenium-webdriver/firefox.js
findFreePortfor dynamic port allocation.ServiceBuilderto include--websocket-portargument.--websocket-portis added only when--connect-existingisabsent.
build()method to handle dynamic port assignment for bothservice and websocket.