feat: custom kafka stream join window #6419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lc525
approved these changes
May 2, 2025
RobertSamoilescu
changed the title
jtayl222
pushed a commit
to jtayl222/seldon-core
that referenced
this pull request
Jul 20, 2025
* Included support for custom join window millis * Pass JoinWindowMs in PipelineStepUpdate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, the
joinWindowMsfor Kafka Streams provided in the manifest file are not passed to the dataflow engine. Dataflow engine uses a predefined value for the length of the joining window (60s). For a pipeline with cycles, this might results in an infinite loop.This PR allows the user to pass a custom value for
joinWindowMswhich will be then used by the dataflow engine for the given pipeline, and thus infinite loop scenarios as above can be avoided.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: