Skip to content

fix(o11s): Filter gpu metrics on exported_namespace #6377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2025

Conversation

sakoush
Copy link
Contributor

@sakoush sakoush commented Apr 3, 2025

DCGM exporter could potentially run in a different namespace but the metrics have a label exported_namespace that points to where the metrics are collected from. We use this instead for filtering.

DCGM exporter could potentially run in a different namespace but the metrics have a label `exported_namespace` that point to where the metrics are collected from. We use this instead for filtering.
@sakoush sakoush requested a review from lc525 as a code owner April 3, 2025 14:30
@sakoush sakoush added the v2 label Apr 3, 2025
Copy link
Member

@lc525 lc525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lc525 lc525 merged commit a1f19ec into v2 Jul 4, 2025
5 checks passed
@lc525 lc525 deleted the quickfix/gpu_dash_filter branch July 4, 2025 12:51
jtayl222 pushed a commit to jtayl222/seldon-core that referenced this pull request Jul 20, 2025
* filter gpu metrics on exported_namespace

DCGM exporter could potentially run in a different namespace but the metrics have a label `exported_namespace` that point to where the metrics are collected from. We use this instead for filtering.

* update other dash accordingly

---------

Co-authored-by: Sherif Akoush <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants