feat: Config logging via helm #6312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 13, 2025 14:04
added 2 commits
March 14, 2025 11:23
lc525
reviewed
Mar 17, 2025
| @@ -53,6 +53,10 @@ spec: | |||
| value: '{{ .Values.security.kafka.ssl.client.endpointIdentificationAlgorithm }}' | |||
| - name: SELDON_CORES_COUNT | |||
| value: '{{ .Values.dataflow.cores }}' | |||
| - name: SELDON_LOG_LEVEL_APP | |||
| value: '{{ hasKey .Values.dataflow "logLevel" | ternary .Values.dataflow.logLevel .Values.logging.logLevel | upper }}' | |||
| - name: SELDON_LOG_LEVEL_KAFKA | |||
There was a problem hiding this comment.
Was initially wondering whether we won't need a similar setup to the go one on the dataflow-engine side, but it appears that it knows how to take the same levels as syslog.
jtayl222
pushed a commit
to jtayl222/seldon-core
that referenced
this pull request
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces logging level configuration, exposed via helm.
Different components can set individual log levels or use a global setting in helm.
For the global setting, users should set
logging.logLevel, possible values are: debug, info, error.If set on individual components, then the allowed levels depend on the underlying logging used for the component. Check docs for more information.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: