Skip to content

fix(ci): fix flaky test #6022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Conversation

sakoush
Copy link
Contributor

@sakoush sakoush commented Nov 1, 2024

What this PR does / why we need it:

This PR fixes a flaky test.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@sakoush sakoush requested a review from lc525 as a code owner November 1, 2024 14:17
@sakoush sakoush added the v2 label Nov 1, 2024
Copy link
Member

@lc525 lc525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after adding max count in the for loops

@sakoush sakoush merged commit cb5cfbd into SeldonIO:v2 Nov 1, 2024
3 checks passed
jtayl222 pushed a commit to jtayl222/seldon-core that referenced this pull request Jul 20, 2025
* fix flaky test

* cap execution of test in case of failures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants