fix: Add server keep alive enforcement policy #6016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
October 29, 2024 16:25
lc525
reviewed
Oct 30, 2024
lc525
reviewed
Oct 30, 2024
lc525
reviewed
Oct 30, 2024
jtayl222
pushed a commit
to jtayl222/seldon-core
that referenced
this pull request
Jul 20, 2025
* add server keep alove policy constants * fix spelling mistakes in constant * remove keep alive from agent->server * scheduler server kaep * use the same constants for client and server keep alive settings * add server (agent) keap * add dataflow server kaep * set keepalive permits to false * add kotlin client keap * set operator client keap * add note * adjust path to file * tidy up keepalive parameters * make constants private * add controller client exp backoff * tidy up client exp backoff * only output log when cleaning resources to reduce log spam * tidy up imports * extract parameters as constants * remove specific grpc operator * set grpc level retries to 100 * set grpc level retries to 100 * add envoy keepalive settings * extra backoff parameters as const * fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds the relevant parameters to make client and server side keep alive work nice together. We should not allow these parameters to be set independently but in some cases they exist in different packages, so manual care is required.
This PR also tidy up some exponential backoff settings.
Which issue(s) this PR fixes: