Skip to content

feat: adding -ldflag and -trimpath to go build #5940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 3, 2024
Merged

feat: adding -ldflag and -trimpath to go build #5940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e07189b
feat: adding -ldflag and -trimpath to go build
abhimanyu003 Sep 27, 2024
6931488
fix: review comments to not to add -s flag
abhimanyu003 Oct 1, 2024
c34826b
fix: review comment and -s flag
abhimanyu003 Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/tls/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
GO_LDFLAGS := -s -w $(patsubst %,-X %, $(GO_BUILD_VARS))
GO_LDFLAGS := -w $(patsubst %,-X %, $(GO_BUILD_VARS))

.PHONY: test
test:
Expand All @@ -18,7 +18,7 @@ lint: ${.GOLANGCILINT_PATH}/golangci-lint

.PHONY: build
build: test
go build ./pkg/...
go build -trimpath -ldflags="-w" ./pkg/...

.PHONY: licenses/dep.txt
licenses/dep.txt:
Expand Down
5 changes: 3 additions & 2 deletions hodometer/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,10 @@ lint: ${.GOLANGCILINT_PATH}/golangci-lint
.PHONY: build-hodometer
build-hodometer: test-hodometer
$(GO_ENV) \
go build \
go build -trimpath \
-o bin/hodometer \
-ldflags=" \
-w \
-X '$(VERSION_PACKAGE).BuildVersion=$(BUILD_VERSION)' \
-X '$(VERSION_PACKAGE).BuildTime=$(BUILD_TIME)' \
-X '$(VERSION_PACKAGE).GitBranch=$(GIT_BRANCH)' \
Expand All @@ -52,7 +53,7 @@ build-hodometer-local: copy-components build-hodometer

.PHONY: build-receiver
build-receiver: test-receiver
$(GO_ENV) go build -o bin/receiver ./cmd/receiver
$(GO_ENV) go build -trimpath -ldflags="-w" -o bin/receiver ./cmd/receiver

.PHONY: build
build: build-hodometer build-receiver
Expand Down
2 changes: 1 addition & 1 deletion operator/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ COPY operator/pkg/ pkg/
COPY operator/main.go main.go

# Build
RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -a -o manager main.go
RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -trimpath -ldflags="-w" -a -o manager main.go

FROM registry.access.redhat.com/ubi9/ubi-micro:9.4-15
WORKDIR /
Expand Down
8 changes: 4 additions & 4 deletions operator/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,20 +88,20 @@ test: manifests generate fmt vet envtest ## Run tests.

.PHONY: build
build: generate fmt vet ## Build manager binary.
go build -o bin/manager main.go
go build -trimpath -ldflags="-w" -o bin/manager main.go

.PHONY: run
run: manifests generate fmt vet ## Run a controller from your host.
go run ./main.go

build-seldon: generate fmt vet
go build -o bin/seldon -v ./cmd/seldon
go build -trimpath -ldflags="-w" -o bin/seldon -v ./cmd/seldon

build-seldon-arm: generate fmt vet
GOOS=darwin GOARCH=arm64 go build -tags dynamic -o bin/seldon -v ./cmd/seldon
GOOS=darwin GOARCH=arm64 go build -trimpath -ldflags="-w" -tags dynamic -o bin/seldon -v ./cmd/seldon

build-seldon-docgen:
go build -o bin/seldon-gendocs -v ./cmd/seldon/docs
go build -trimpath -ldflags="-w" -o bin/seldon-gendocs -v ./cmd/seldon/docs

generate-cli-docs:
./bin/seldon-gendocs --out ../docs/source/contents/cli/docs
Expand Down
16 changes: 8 additions & 8 deletions scheduler/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,39 +24,39 @@ GID ?= $(shell id -g)

KIND_NAME=seldon

GO_LDFLAGS := -s -w $(patsubst %,-X %, $(GO_BUILD_VARS))
GO_LDFLAGS := -w $(patsubst %,-X %, $(GO_BUILD_VARS))

#####################################
# Build
#####################################

.PHONY: build-scheduler
build-scheduler: test-go
go build -buildvcs=false -o bin/scheduler ./cmd/scheduler
go build -trimpath -ldflags="-w" -buildvcs=false -o bin/scheduler ./cmd/scheduler

.PHONY: build-proxy
build-proxy: test-go
CGO_ENABLED=0 go build -o bin/proxy ./cmd/proxy
CGO_ENABLED=0 go build -trimpath -ldflags="-w" -o bin/proxy ./cmd/proxy

.PHONY: build-agent
build-agent: test-go
CGO_ENABLED=0 go build -buildvcs=false -o bin/agent ./cmd/agent
CGO_ENABLED=0 go build -trimpath -ldflags="-w" -buildvcs=false -o bin/agent ./cmd/agent

.PHONY: build-modelgateway
build-modelgateway: test-go
go build -o bin/modelgateway -v ./cmd/modelgateway
go build -trimpath -ldflags="-w" -o bin/modelgateway -v ./cmd/modelgateway

.PHONY: build-pipelinegateway
build-pipelinegateway: test-go
go build -o bin/pipelinegateway -v ./cmd/pipelinegateway
go build -trimpath -ldflags="-w" -o bin/pipelinegateway -v ./cmd/pipelinegateway

.PHONY: build-dataflow-producer
build-dataflow-producer: test-jvm
go build -o data-flow/scripts/bin/producer ./data-flow/scripts/producer.go ./data-flow/scripts/common.go
go build -trimpath -ldflags="-w" -o data-flow/scripts/bin/producer ./data-flow/scripts/producer.go ./data-flow/scripts/common.go

.PHONY: build-dataflow-consumer
build-dataflow-consumer:
go build -o data-flow/scripts/bin/consumer ./data-flow/scripts/consumer.go ./data-flow/scripts/common.go
go build -trimpath -ldflags="-w" -o data-flow/scripts/bin/consumer ./data-flow/scripts/consumer.go ./data-flow/scripts/common.go

.PHONY: build-dataflow-engine
build-dataflow-engine:
Expand Down
Loading