Skip to content

fix: Upgrade go 1.21 and golint to 1.57 #5556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 1, 2024
Merged

fix: Upgrade go 1.21 and golint to 1.57 #5556

merged 5 commits into from
May 1, 2024

Conversation

sakoush
Copy link
Contributor

@sakoush sakoush commented Apr 30, 2024 •
edited
Loading

This PR moves to:

FIXES: INFRA-990 (internal)

TODO:

  • smoke test on kind

@sakoush sakoush added the v2 label Apr 30, 2024
@sakoush sakoush removed the request for review from RafalSkolasinski May 1, 2024 10:07
lc525
lc525 approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@lc525 lc525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sakoush sakoush merged commit 8067816 into SeldonIO:v2 May 1, 2024
jtayl222 pushed a commit to jtayl222/seldon-core that referenced this pull request Jul 20, 2025
fix: Upgrade go 1.21 and golint to 1.57 (SeldonIO#5556)
b332257 
* upgrade to golang 1.21

* go mod tidy

* upgrade linter to v1.57.2

* upgrade lint worfklow to v1.57.2

* increase timeout for lint workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lc525 lc525 lc525 approved these changes

Assignees
No one assigned
Labels
v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sakoush @lc525