bump(librdkafka): from v1.9.2 to v2.3.0 #5321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakoush
approved these changes
Feb 15, 2024
|
The jvm side doesn't use librdkafka afaik, but directly uses the jvm kafka-streams implementation. Converting this to a draft as I have seen model/pipeline gateway start issuing some certificate errors when testing with external kafka (and OAUTHBEARER). I need to evaluate the impact of those. |
- update needed for automatic re-authentication of kafka connections via SASL (used when connecting to Confluent Cloud via OAUTHBEARER)
librdkafka uses libcurl for fetching OIDC tokens. However, depending on OS, the location where the certs ca-bundle for validating the tls connection between librdkafka and the auth provider is searched differs. We now copy the ca cert bundle to multiple paths to make sure it is found. While this is a bit hacky, there are limited alternatives we can take because: - until now (with librdkafka 1.9.2) those certs were searched under /etc/ssl/certs/ca-certificates.crt but after the update they are searched under /etc/pki/tls/certs/ca-bundle.crt - libcurl doesn't get passed/doesn't respect the caCert location or .pem file set via librdkafka/kafka configs (see confluentinc/librdkafka#375). - there is no way clear way to influence the libcurl search path via env vars (setting the CURL_CA_BUNDLE env var has no effect), with search paths fully decided at compile-time. The likely chain of reasons this has popped-up when updating librdkafka to v2.3.0: - we're building {model, pipeline}gateway docker images based on debian bullseye image - we're copying the build results into redhat ubi9 container - libcurl was statically built in previous librdkafka, so was using the debian search paths on ubi9 - libcurl ends up being dynamically linked in the current librdkafka (to ubi9 version) or has changed its default ca bundle search path
lc525
force-pushed
the
bump-librdkafka
branch
from
d761832 to
4f396c8
Compare
jtayl222
pushed a commit
to jtayl222/seldon-core
that referenced
this pull request
Jul 20, 2025
* bump(librdkafka): from v1.9.2 to v2.3.0 - update needed for automatic re-authentication of kafka connections via SASL (used when connecting to Confluent Cloud via OAUTHBEARER) * fix(librdkafka): Copy certs bundle to path expected by librdkafka v2.3.0 librdkafka uses libcurl for fetching OIDC tokens. However, depending on OS, the location where the certs ca-bundle for validating the tls connection between librdkafka and the auth provider is searched differs. We now copy the ca cert bundle to multiple paths to make sure it is found. While this is a bit hacky, there are limited alternatives we can take because: - until now (with librdkafka 1.9.2) those certs were searched under /etc/ssl/certs/ca-certificates.crt but after the update they are searched under /etc/pki/tls/certs/ca-bundle.crt - libcurl doesn't get passed/doesn't respect the caCert location or .pem file set via librdkafka/kafka configs (see confluentinc/librdkafka#375). - there is no way clear way to influence the libcurl search path via env vars (setting the CURL_CA_BUNDLE env var has no effect), with search paths fully decided at compile-time. The likely chain of reasons this has popped-up when updating librdkafka to v2.3.0: - we're building {model, pipeline}gateway docker images based on debian bullseye image - we're copying the build results into redhat ubi9 container - libcurl was statically built in previous librdkafka, so was using the debian search paths on ubi9 - libcurl ends up being dynamically linked in the current librdkafka (to ubi9 version) or has changed its default ca bundle search path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update needed for automatic re-authentication of kafka connections via SASL (used when connecting to Confluent Cloud via OAUTHBEARER)