Skip to content

avoid failure of plot_feature_outlier_image #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 24, 2023
Merged

avoid failure of plot_feature_outlier_image #774

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dc0eb26
avoid failure of plot_feature_outlier_image
signupatgmx Apr 19, 2023
170109a
remove whitespace in blank line
signupatgmx Apr 20, 2023
3c442a6
Add warning message to plot_feature_outlier_image
mauicv Apr 24, 2023
ef8afe8
Add missing warnings import
mauicv Apr 24, 2023
d98f9af
Remove stacklevel from warning
mauicv Apr 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions alibi_detect/utils/visualize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import pandas as pd
from sklearn.metrics import roc_curve, auc
from typing import Dict, Union
import warnings


def plot_instance_score(preds: Dict,
Expand Down Expand Up @@ -77,6 +78,11 @@ def plot_feature_outlier_image(od_preds: Dict,
instance_ids = list(range(len(od_preds['data']['is_outlier'])))
n_instances = min(max_instances, len(instance_ids))
instance_ids = instance_ids[:n_instances]

if outliers_only and n_instances == 0:
warnings.warn('No outliers found!', UserWarning, stacklevel=3)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mauicv is the warning swallowed without stacklevel=3?

Copy link
Contributor

@mauicv mauicv Apr 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I've removed it!

return

n_cols = 2

if n_channels == 3:
Expand Down