Skip to content

Conversation

@jklaise
Copy link
Contributor

@jklaise jklaise commented Jan 12, 2023

For discussion see here: SeldonIO/alibi#849 (comment)

@jklaise jklaise requested a review from ascillitoe January 12, 2023 09:58
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2023

Codecov Report

Merging #712 (73244ec) into master (21cbea1) will increase coverage by 3.49%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #712      +/-   ##
==========================================
+ Coverage   76.65%   80.15%   +3.49%     
==========================================
  Files         133      133              
  Lines        9177     9177              
==========================================
+ Hits         7035     7356     +321     
+ Misses       2142     1821     -321     
Flag Coverage Δ
macos-latest-3.10 76.65% <ø> (ø)
ubuntu-latest-3.10 80.04% <ø> (?)
ubuntu-latest-3.7 79.94% <ø> (?)
ubuntu-latest-3.8 79.99% <ø> (?)
ubuntu-latest-3.9 79.99% <ø> (?)
windows-latest-3.9 76.58% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
alibi_detect/saving/loading.py 93.71% <0.00%> (+0.48%) ⬆️
alibi_detect/cd/base.py 90.97% <0.00%> (+1.66%) ⬆️
alibi_detect/utils/frameworks.py 92.59% <0.00%> (+3.70%) ⬆️
alibi_detect/cd/learned_kernel.py 100.00% <0.00%> (+4.34%) ⬆️
alibi_detect/utils/_types.py 100.00% <0.00%> (+4.76%) ⬆️
alibi_detect/cd/mmd.py 97.72% <0.00%> (+6.81%) ⬆️
alibi_detect/saving/registry.py 100.00% <0.00%> (+10.71%) ⬆️
alibi_detect/saving/validators.py 90.38% <0.00%> (+13.46%) ⬆️
alibi_detect/saving/_keops/loading.py 88.23% <0.00%> (+76.47%) ⬆️
alibi_detect/cd/keops/learned_kernel.py 94.16% <0.00%> (+94.16%) ⬆️
... and 2 more

Copy link
Contributor

@ascillitoe ascillitoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge. Shall we open an issue to investigate some of the long run times? Or just leave it until (if) they become problematic?

@jklaise
Copy link
Contributor Author

jklaise commented Jan 12, 2023

Don't mind either way.

@ascillitoe
Copy link
Contributor

I vote for lets merge! Leave the investigation for the future

@ascillitoe ascillitoe merged commit 7d6739c into SeldonIO:master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants