Skip to content

Conversation

@ascillitoe
Copy link
Contributor

Fixes #706

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2023

Codecov Report

Merging #710 (7ce6476) into master (f0b57b4) will increase coverage by 3.38%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #710      +/-   ##
==========================================
+ Coverage   76.65%   80.04%   +3.38%     
==========================================
  Files         133      133              
  Lines        9177     9177              
==========================================
+ Hits         7035     7346     +311     
+ Misses       2142     1831     -311     
Flag Coverage Δ
macos-latest-3.10 ?
ubuntu-latest-3.10 80.04% <100.00%> (?)
ubuntu-latest-3.9 79.99% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
alibi_detect/cd/tensorflow/mmd_online.py 98.48% <100.00%> (ø)
alibi_detect/utils/frameworks.py 88.88% <0.00%> (ø)
alibi_detect/saving/loading.py 93.71% <0.00%> (+0.48%) ⬆️
alibi_detect/cd/base.py 90.97% <0.00%> (+1.66%) ⬆️
alibi_detect/cd/learned_kernel.py 100.00% <0.00%> (+4.34%) ⬆️
alibi_detect/cd/mmd.py 97.72% <0.00%> (+6.81%) ⬆️
alibi_detect/saving/registry.py 100.00% <0.00%> (+10.71%) ⬆️
alibi_detect/saving/_keops/loading.py 88.23% <0.00%> (+76.47%) ⬆️
alibi_detect/cd/keops/learned_kernel.py 94.16% <0.00%> (+94.16%) ⬆️
alibi_detect/utils/keops/kernels.py 98.01% <0.00%> (+97.02%) ⬆️
... and 1 more

@ascillitoe ascillitoe requested review from mauicv and ojcobb January 11, 2023 15:39
Copy link
Contributor

@mauicv mauicv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ascillitoe ascillitoe merged commit 71d41ef into SeldonIO:master Jan 13, 2023
@ascillitoe ascillitoe deleted the fix/tf_indexing_bug branch January 13, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intermittent IndexError in MMDDriftOnlineTF with older Python (and tensorflow?) versions

3 participants