Added JSON_VALUE for mysql platform #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hikariii
force-pushed
the
mysql/json-value
branch
from
671f86f to
3333cee
Compare
annervisser
suggested changes
Oct 18, 2024
Available is imo the needed addition. It will be available twice. You still have to register every function separately, so they will not conflict if you pick what you need. |
@Hikariii All other JSON functions in this repo's MySQL directory are also available (and identical) in MariaDB. It seems inconsistent to only have the JsonValue duplicated. |
Hikariii
force-pushed
the
mysql/json-value
branch
from
3333cee to
380e951
Compare
Hikariii
force-pushed
the
mysql/json-value
branch
from
380e951 to
dca5364
Compare
|
@annervisser I just updated json_value to be mysql specific. |
annervisser
approved these changes
Nov 8, 2024
Hikariii
requested review from
HarmenM,
alleknalle,
luukvhoudt and
NvanWeeghel
HarmenM
approved these changes
Nov 8, 2024
alleknalle
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #82