refactor: make lib/* into extensions #517
Conversation
sathvikbhagavan
changed the title
sathvikbhagavan
force-pushed
the
sb/extensions
branch
from
45edbfe to
ca8014c
Compare
sathvikbhagavan
force-pushed
the
sb/extensions
branch
from
ca8014c to
4e8be11
Compare
|
@ChrisRackauckas, can you take a look? I have converted all the lib/ packages into extensions. After this, I will update the docs in a separate PR. |
|
Looks fine but the docs need to be updated to not be importing the old libraries. |
sathvikbhagavan
force-pushed
the
sb/extensions
branch
from
d865807 to
5548631
Compare
sathvikbhagavan
force-pushed
the
sb/extensions
branch
from
020585a to
c12c45f
Compare
sathvikbhagavan
force-pushed
the
sb/extensions
branch
from
fb17003 to
7f205da
Compare
|
@ChrisRackauckas, I have fixed the docs and downgrade CI as well. |
Project.toml
Outdated
|
|
||
| [extensions] | ||
| SurrogatesAbstractGPsExt = "AbstractGPs" | ||
| SurrogatesFluxExt = ["Flux", "Optimisers"] |
There was a problem hiding this comment.
Optimisers being necessary will need to be clearly documented.
There was a problem hiding this comment.
Yes, i will document it.
ext/SurrogatesFluxExt.jl
Outdated
|
|
||
| using Surrogates: NeuralSurrogate | ||
| using SurrogatesBase | ||
| using Optimisers |
There was a problem hiding this comment.
Optimizers is in Flux though?
There was a problem hiding this comment.
Hmm, I thought that was deprecated in favour of using Optimisers.jl
There was a problem hiding this comment.
It's still baked in there, so that makes the extension easier.
Co-authored-by: Sathvik Bhagavan <[email protected]>
2 participants
Fixes: #513