refactor: SurrogatesRandomForest with SurrogatesBase

[sathvikbhagavan]

Next in line after #475

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 65.83%. Comparing base (26b5705) to head (a20c8d5).

Files	Patch %	Lines
...rrogatesRandomForest/src/SurrogatesRandomForest.jl	0.00%	14 Missing ⚠️
lib/SurrogatesSVM/src/SurrogatesSVM.jl	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master     #477       +/-   ##
===========================================
- Coverage   78.22%   65.83%   -12.40%     
===========================================
  Files          23       23               
  Lines        3136     3108       -28     
===========================================
- Hits         2453     2046      -407     
- Misses        683     1062      +379     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ChrisRackauckas]

The doc build failure looks real?

[sathvikbhagavan]

Yeah, it is because surrogate_optimize takes in AbstractSurrogate defined in Surrogates.jl but SurrogatesRandomForest now uses type from SurrogatesBase.jl. I think it should be fine for now. My plan is to refactor the remaining subpackages first and then I will fix surrogate_optimize and docs. Does that sound ok?

[ChrisRackauckas]

yes