Skip to content

Delete overwriting function #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2023
Merged

Delete overwriting function #387

merged 1 commit into from
Jan 27, 2023

Conversation

chriselrod
Copy link
Contributor 

julia> using Sundials
[ Info: Precompiling Sundials [c3572dad-4567-51f8-b174-8c6c989267f4]
WARNING: Method definition KINSetSysFunc(Any, Ptr{Nothing}) in module Sundials at /home/chriselrod/.julia/packages/Sundials/639C2/lib/libsundials_api.jl:5107 overwritten at /home/chriselrod/.julia/packages/Sundials/639C2/lib/libsundials_api.jl:5111.
  ** incremental compilation may be fatally broken for this module **

@chriselrod
Delete overwriting function
cca393a 
```julia
julia> using Sundials
[ Info: Precompiling Sundials [c3572dad-4567-51f8-b174-8c6c989267f4]
WARNING: Method definition KINSetSysFunc(Any, Ptr{Nothing}) in module Sundials at /home/chriselrod/.julia/packages/Sundials/639C2/lib/libsundials_api.jl:5107 overwritten at /home/chriselrod/.julia/packages/Sundials/639C2/lib/libsundials_api.jl:5111.
  ** incremental compilation may be fatally broken for this module **
```
ChrisRackauckas
ChrisRackauckas approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@ChrisRackauckas ChrisRackauckas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that looks unnecessary lol

@codecov
Copy link

codecov bot commented Jan 27, 2023 •
edited
Loading

Codecov Report

Merging #387 (cca393a) into master (aa5681f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #387   +/-   ##
=======================================
  Coverage   78.26%   78.26%           
=======================================
  Files          11       11           
  Lines        1463     1463           
=======================================
  Hits         1145     1145           
  Misses        318      318

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChrisRackauckas ChrisRackauckas merged commit 0636df4 into SciML:master Jan 27, 2023
@chriselrod chriselrod deleted the patch-1 branch January 27, 2023 23:36
@ChrisRackauckas ChrisRackauckas mentioned this pull request Jan 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisRackauckas ChrisRackauckas ChrisRackauckas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chriselrod @ChrisRackauckas